From: "Mark Hamilton" <mark_lee_hamilton@sbcglobal.net>
To: "Estelle HAMMACHE" <estelle.hammache@st.com>,
<linux-mtd@lists.infradead.org>
Subject: Re: [JFFS2] GC patch for eCos port
Date: Tue, 9 Nov 2004 13:26:09 -0800 [thread overview]
Message-ID: <020101c4c6a2$c9ae6e30$0101000a@mark> (raw)
In-Reply-To: 416A7A0A.591B4A03@st.com
Estelle,
Sorry for not getting back to you sooner on this. I agree that ideally I
would prefer to see a fix done in the eCos port of JFFS2. I'll try your
suggestion and rerun my tests to make sure that something isn't overlooked.
Hopefully, I can resubmit a patch to the eCos group.
-Mark
----- Original Message -----
From: "Estelle HAMMACHE" <estelle.hammache@st.com>
To: "Mark Hamilton" <mhamilton@alliantnetworks.com>;
<linux-mtd@lists.infradead.org>
Sent: Monday, October 11, 2004 4:18 AM
Subject: Re: [JFFS2] GC patch for eCos port
> Estelle Hammache wrote:
> >
> > Hi Mark,
> >
> > isn't it cleaner (for compatibility with Linux) to modify
> > jffs2_gc_fetch_page so that it reads a
> > PAGE_CACHE_SIZE-aligned buffer ?
>
> Ok so this was discussed in the eCos mailing list, but I meant that
> jffs2_gc_fetch_page should call jffs2_read_inode with the reading
> offset set to the page boundary: (offset & ~(PAGE_CACHE_SIZE-1)).
> I believe this is the expected behavior for jffs2_gc_fetch_page.
>
> Estelle
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2004-11-09 21:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-08 19:37 GC patch for eCos port Mark Hamilton
2004-10-11 8:49 ` [JFFS2] " Estelle HAMMACHE
2004-10-11 12:18 ` Estelle HAMMACHE
2004-11-09 21:26 ` Mark Hamilton [this message]
2004-11-11 11:27 ` David Woodhouse
2004-11-11 13:19 ` Per Hedblom
2004-11-11 13:58 ` David Woodhouse
2004-11-11 15:50 ` Per Hedblom
2004-11-11 16:02 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='020101c4c6a2$c9ae6e30$0101000a@mark' \
--to=mark_lee_hamilton@sbcglobal.net \
--cc=estelle.hammache@st.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox