public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <gleixner@autronix.de>
To: David Woodhouse <dwmw2@infradead.org>, linux-mtd@lists.infradead.org
Subject: JFFS2 on NAND flash
Date: Thu, 31 Jan 2002 11:04:10 +0100	[thread overview]
Message-ID: <02013022481901.00763@thomas> (raw)
In-Reply-To: <15998.1007200283@redhat.com>

Smile !

I tried jffs2 on a NAND flash. Tracking down one ugly bug in fs/jffs2/write.c 
i got it basicly working !
Thanks to all of you, who did his job on that jffs2/nand stuff obviously 
without having access to a NAND device.

Bug description
If you write a file a empty dnode is created first.
jffs2_do_create calls 
	jfss2_write_dnode(c, f, ri, NULL, 0, phys_ofs, &writtenlen);

jfss2_write_dnode puts NULL & 0 , which is data and datalen into
	vecs[1].iov_base = (unsigned char *)data;
	vecs[1].iov_len = datalen;
and then calls 
	ret = jffs2_flash_writev(c, vecs, 2, flash_ofs, &retlen); 
2 is the number of vecs assigned to this job.

jffs2_flash_writev calls mtd->writev, if available else it calls
mtd_fake_writev. The nand driver supports writev and does not check if the 
vecs[1] entry is empty. mtd_fake_writev takes care of this.
I suggest to do the check in jffs_write_dnode (where the wrong count comes 
from), although i will include a check in nand.c.
This problem did not show up due to the fact, that obviously none of the 
FLASH drivers supports writev. (I could not find one in mtd)

Patch is committed to CVS

Thomas
__________________________________________________
Thomas Gleixner, autronix automation GmbH
auf dem berg 3, d-88690 uhldingen-muehlhofen
fon: +49 7556 919891 , fax: +49 7556 919886
mail: gleixner@autronix.de, http://www.autronix.de  

  reply	other threads:[~2002-01-31  9:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-01  9:51 JFFS2 on NAND flash/DiskOnChip David Woodhouse
2002-01-31 10:04 ` Thomas Gleixner [this message]
2002-01-31 10:22   ` JFFS2 on NAND flash David Woodhouse
2002-01-31 12:26     ` Thomas Gleixner
2002-01-31 14:29       ` Thomas Gleixner
2002-01-31 14:30       ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02013022481901.00763@thomas \
    --to=gleixner@autronix.de \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox