public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <gleixner@autronix.de>
To: David Woodhouse <dwmw2@infradead.org>, gleixner@autronix.de
Cc: linux-mtd@lists.infradead.org
Subject: Re: JFFS2 on NAND flash
Date: Thu, 31 Jan 2002 13:26:02 +0100	[thread overview]
Message-ID: <02013113260208.00763@thomas> (raw)
In-Reply-To: <17832.1012472563@redhat.com>

On Thursday, 31. January 2002 11:22, David Woodhouse wrote:
> Be careful. You have nothing there to make sure that it doesn't violate the
> constraints on the number of write cycles per page. You have no ECC, you
> have no real chance of it working in the wild.
I know that and i was trying to put a workaround for the write cycle problem 
into the nand driver. I think thats the correct location for this. Are there 
other chips dealing with the same problem or is it related to NAND only ?
My current solutiun would be:
In nand.c the write functions checks the write attempts to a page. If there 
were three writes already to this page, the function reads back the block 
data, erases the block and writes the block data back to the chip. 

Is this also a problem for jffs1 ? I run jffs1 for a couple of weeks on my 
board and had not one problem at all. 

> Also note that the locking in jffs2_garbage_collect_deletion_dirent() is
> broken. We need to lock the erase_completion_lock while we go through the
> list, and drop the lock when we read the nodes.
I'm not deep enough inside this to see the neccecary change. Could you please 
explain more detailed ?

> All the writev stuff was put there for the benefit of NAND flash - so yes,
> nobody's used it yet. This problem had come up recently in the eCos port,
> but the fix hadn't yet propagated to the main tree.
No problem it took only some time to understand what happens there.

Thomas
__________________________________________________
Thomas Gleixner, autronix automation GmbH
auf dem berg 3, d-88690 uhldingen-muehlhofen
fon: +49 7556 919891 , fax: +49 7556 919886
mail: gleixner@autronix.de, http://www.autronix.de  

  reply	other threads:[~2002-01-31 12:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-01  9:51 JFFS2 on NAND flash/DiskOnChip David Woodhouse
2002-01-31 10:04 ` JFFS2 on NAND flash Thomas Gleixner
2002-01-31 10:22   ` David Woodhouse
2002-01-31 12:26     ` Thomas Gleixner [this message]
2002-01-31 14:29       ` Thomas Gleixner
2002-01-31 14:30       ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02013113260208.00763@thomas \
    --to=gleixner@autronix.de \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox