public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <gleixner@autronix.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org, jffs-dev@axis.com
Subject: Re: JFFS2 & NAND
Date: Mon, 18 Feb 2002 17:02:59 +0100	[thread overview]
Message-ID: <02021817025909.00860@thomas> (raw)
In-Reply-To: <02021810483303.00860@thomas>

I hacked it, so that JFFS2 uses the c->mtd->ecctype to decide which oob 
layout is given. I tested the system again and destroyed the ECC data on one 
page. When i tried to mount JFFS2 again it failed, because the nand driver 
returned -EIO, as the bad page ECC was seen. 
That's not the way it can go. You have one bad ECC page and all your data are 
lost. 
There are two possibilities to react:
1. Return the raw page data without ECC correction and return 0 (success) and 
let the fs driver detect the invalid stuff on it's own, what JFFS2 actually 
does.

2. Return the raw page data without ECC correction and return a value > 0 to 
inform the fs driver that ECC failed and data maybe corrupted.

I think the 2nd one is the better one. But it gives us a lot of hacking 
inside JFFS2.

-- 
Thomas
__________________________________________________
Thomas Gleixner, autronix automation GmbH
auf dem berg 3, d-88690 uhldingen-muehlhofen
fon: +49 7556 919891 , fax: +49 7556 919886
mail: gleixner@autronix.de, http://www.autronix.de  

      reply	other threads:[~2002-02-18 15:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-14 15:57 JFFS2 & NAND Thomas Gleixner
2002-02-14 17:22 ` Peter De Schrijver
2002-02-14 17:27 ` David Woodhouse
2002-02-14 17:43   ` Thomas Gleixner
2002-02-17  9:51     ` David Woodhouse
2002-02-17 11:44       ` Thomas Gleixner
2002-02-17 17:25         ` David Woodhouse
2002-02-17 19:36           ` Thomas Gleixner
2002-02-18  8:48             ` Thomas Gleixner
2002-02-18  8:46               ` David Woodhouse
2002-02-18  9:26                 ` Thomas Gleixner
2002-02-18  9:29                   ` David Woodhouse
2002-02-18  9:48                     ` Thomas Gleixner
2002-02-18 16:02                       ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02021817025909.00860@thomas \
    --to=gleixner@autronix.de \
    --cc=dwmw2@infradead.org \
    --cc=jffs-dev@axis.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox