From: "Sudhakar Rajashekhara" <sudhakar.raj@ti.com>
To: "'David Brownell'" <david-b@pacbell.net>,
"'David Woodhouse'" <dwmw2@infradead.org>,
"'Kevin Hilman'" <khilman@deeprootsystems.com>
Cc: 'Bernd Schmidt' <bernd.schmidt@analog.com>,
'David Brownell' <dbrownell@users.sourceforge.net>,
'Nicolas Pitre' <nico@fluxnic.net>,
linux-kernel@vger.kernel.org,
'David Howells' <dhowells@redhat.com>,
linux-mtd@lists.infradead.org,
'Andrew Morton' <akpm@linux-foundation.org>
Subject: RE: [PATCH 1/2] mtdpart: memory accessor interface for MTD layer
Date: Thu, 8 Jul 2010 20:40:09 +0530 [thread overview]
Message-ID: <027001cb1eaf$a7dc64e0$f7952ea0$@raj@ti.com> (raw)
In-Reply-To: <54038.80733.qm@web180305.mail.gq1.yahoo.com>
Hi Dave,
On Wed, Jul 07, 2010 at 16:38:54, David Brownell wrote:
>
> > > > This patch adds two new members to the
> > mtd_partition structure,
> > > > a function handler which will be
> > > > called during setup of the
> > > > partition and an argument to be passed to this
> > setup function.
> > >
> > > Ick.
> > >
> > > I don't mind providing the mtd_macc_{read,write}
> > helper functions,
> > > although they should work on generic MTD
> > > >devices not just on partitions.
> > > But do we really have to do the callout to
> > > arbitrary functions from
> > > _within_ the core MTD code... why can't we
> > > do that in the board driver?
>
> I think the short answer is that the callout is
> what provides the board drivers enough information
> to make the correct calls.
>
If you agree to what the patch is doing, then can you Ack it?
Thanks,
Sudhakar
next prev parent reply other threads:[~2010-07-08 15:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 20:41 [PATCH 1/2] mtdpart: memory accessor interface for MTD layer Kevin Hilman
2010-04-08 8:10 ` Artem Bityutskiy
2010-05-13 23:50 ` David Woodhouse
2010-07-07 10:56 ` Sudhakar Rajashekhara
2010-07-07 11:08 ` David Brownell
2010-07-08 15:10 ` Sudhakar Rajashekhara [this message]
2010-07-08 16:00 ` David Brownell
2010-08-04 10:12 ` David Woodhouse
2010-08-04 10:31 ` David Brownell
2010-08-04 11:08 ` David Woodhouse
2010-08-04 11:27 ` David Brownell
2010-08-06 6:48 ` Sudhakar Rajashekhara
2010-08-08 12:23 ` David Woodhouse
2010-08-09 11:55 ` Sudhakar Rajashekhara
-- strict thread matches above, loose matches on Subject: below --
2010-10-01 21:16 [patch " akpm
2010-10-02 14:09 ` Artem Bityutskiy
2010-10-02 14:44 ` David Woodhouse
2010-10-04 14:28 ` Sudhakar Rajashekhara
2010-10-02 19:09 ` Andrew Morton
2010-10-20 22:59 akpm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='027001cb1eaf$a7dc64e0$f7952ea0$@raj@ti.com' \
--to=sudhakar.raj@ti.com \
--cc=akpm@linux-foundation.org \
--cc=bernd.schmidt@analog.com \
--cc=david-b@pacbell.net \
--cc=dbrownell@users.sourceforge.net \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=khilman@deeprootsystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).