From: "Sudhakar Rajashekhara" <sudhakar.raj@ti.com>
To: "'Wolfram Sang'" <w.sang@pengutronix.de>,
<linux-mtd@lists.infradead.org>
Cc: 'Artem Bityutskiy' <Artem.Bityutskiy@nokia.com>,
davinci-linux-open-source@linux.davincidsp.com,
'Sneha Narnakaje' <nsnehaprabha@ti.com>
Subject: RE: [RFC] nand/davinci: Fix comment to match the code
Date: Wed, 25 Aug 2010 17:57:40 +0530 [thread overview]
Message-ID: <039d01cb4450$e8f7d6a0$bae783e0$@raj@ti.com> (raw)
In-Reply-To: <1282738700-30966-1-git-send-email-w.sang@pengutronix.de>
Hi,
On Wed, Aug 25, 2010 at 17:48:20, Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Cc: Sudhakar Rajashekhara <sudhakar.raj@ti.com>
> Cc: Sneha Narnakaje <nsnehaprabha@ti.com>
> Cc: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
> ---
>
> Found while debugging a NAND issue with a dm365.
>
> drivers/mtd/nand/davinci_nand.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
> index 2ac7367..53f864a 100644
> --- a/drivers/mtd/nand/davinci_nand.c
> +++ b/drivers/mtd/nand/davinci_nand.c
> @@ -369,8 +369,9 @@ compare:
> * after setting the 4BITECC_ADD_CALC_START bit. So if you immediately
> * begin trying to poll for the state, you may fall right out of your
> * loop without any of the correction calculations having taken place.
> - * The recommendation from the hardware team is to wait till ECC_STATE
> - * reads less than 4, which means ECC HW has entered correction state.
> + * The recommendation from the hardware team is to initially delay as
> + * long as ECC_STATE reads less than 4. After that, ECC HW has entered
> + * correction state.
> */
> do {
> ecc_state = (davinci_nand_readl(info,
> --
Thanks for pointing this out, but I have already corrected this and submitted
the patch. Artem Bityutskity has pushed this patch to his l2-mtd-2.6 / master
tree.
Regards,
Sudhakar
next prev parent reply other threads:[~2010-08-25 12:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 12:18 [RFC] nand/davinci: Fix comment to match the code Wolfram Sang
2010-08-25 12:27 ` Sudhakar Rajashekhara [this message]
2010-08-25 12:55 ` Artem Bityutskiy
2010-08-25 13:30 ` Wolfram Sang
2010-08-26 3:59 ` Sudhakar Rajashekhara
2010-08-26 6:23 ` Wolfram Sang
2010-09-01 8:05 ` Wolfram Sang
2010-09-01 23:14 ` Artem Bityutskiy
2010-09-03 10:35 ` [PATCH] nand/davinci: relax a timeout for ECC-initialization Wolfram Sang
2010-09-03 11:12 ` Sudhakar Rajashekhara
2010-09-03 12:15 ` Wolfram Sang
2010-09-07 8:00 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='039d01cb4450$e8f7d6a0$bae783e0$@raj@ti.com' \
--to=sudhakar.raj@ti.com \
--cc=Artem.Bityutskiy@nokia.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-mtd@lists.infradead.org \
--cc=nsnehaprabha@ti.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).