Re: [PATCH v2] mtd: spinand: Add support for AllianceMemory AS5F34G04SND

Miquel Raynal
2023-01-26T14:58:53Z

Hello,

dev@kicherer.org wrote on Thu, 26 Jan 2023 15:34:47 +0100:

> Hello Miquèl,
>
> I made all requested changes and added additional code to make the ooblayout
> functions compatible with all flashes of this series.
>
> I also ran nandbiterrs with the following result:
>
> # nandbiterrs -i /dev/mtd11
> incremental biterrors test
> Successfully corrected 0 bit errors per subpage
> Inserted biterror @ 0/5
> Read reported 7 corrected bit errors
> Successfully corrected 1 bit errors per subpage

Yeah, well, I guess we don't have a choice. UBI would see this as a
need to rewrite the block somewhere else because of the too high amount
of bit flips. UBI's threshold is somewhere around 3/4 or the strength,
so these flashes could rapidly wear out, but I don't think we have
another choice.

> Inserted biterror @ 0/2
> Read reported 7 corrected bit errors
> Successfully corrected 2 bit errors per subpage
> Inserted biterror @ 0/0
> Read reported 7 corrected bit errors
> Successfully corrected 3 bit errors per subpage
> Inserted biterror @ 1/7
> Read reported 7 corrected bit errors
> Successfully corrected 4 bit errors per subpage
> Inserted biterror @ 1/5
> Read reported 7 corrected bit errors
> Successfully corrected 5 bit errors per subpage
> Inserted biterror @ 1/2
> Read reported 7 corrected bit errors
> Successfully corrected 6 bit errors per subpage
> Inserted biterror @ 1/0
> Read reported 7 corrected bit errors
> Successfully corrected 7 bit errors per subpage
> Inserted biterror @ 2/6
> Read reported 8 corrected bit errors
> Successfully corrected 8 bit errors per subpage
> Inserted biterror @ 2/5
> Failed to recover 1 bitflips
> Read error after 9 bit errors per page
>
> I would say this looks good?
>
> I will send the new patch in a few seconds.
>
> Thank you!
> Mario