From: Kyungmin Park <kyungmin.park@samsung.com>
To: 'Adrian Hunter' <adrian.hunter@nokia.com>,
'Kyungmin Park' <kmpark@infradead.org>
Cc: 'linux-mtd Mailing List' <linux-mtd@lists.infradead.org>,
"'Tereshonkov Roman \(Nokia-D/Helsinki\)'"
<roman.tereshonkov@nokia.com>
Subject: RE: 4KiB page OneNAND OOB
Date: Thu, 27 Jan 2011 18:59:40 +0900 [thread overview]
Message-ID: <0a2301cbbe08$ea2d8a60$be889f20$%park@samsung.com> (raw)
In-Reply-To: <4D413FBC.4080403@nokia.com>
Hi Adrian,
Umm strange, I also got the 4KiB page OneNAND, but it has 4 bytes free from
2 at each spare area, So current code is right.
8011h 10022h Managed by internal ECC logic
8012h 10024h Managed by internal ECC logic
Thank you,
Kyungmin Park
-----Original Message-----
From: Adrian Hunter [mailto:adrian.hunter@nokia.com]
Sent: Thursday, January 27, 2011 6:50 PM
To: Kyungmin Park; Kyungmin Park
Cc: linux-mtd Mailing List; Tereshonkov Roman (Nokia-D/Helsinki)
Subject: 4KiB page OneNAND OOB
Hi
Current onenand_base.c has
/**
* onenand_oob_128 - oob info for Flex-Onenand with 4KB page
* For now, we expose only 64 out of 80 ecc bytes
*/
static struct nand_ecclayout onenand_oob_128 = {
.eccbytes = 64,
.eccpos = {
6, 7, 8, 9, 10, 11, 12, 13, 14, 15,
22, 23, 24, 25, 26, 27, 28, 29, 30, 31,
38, 39, 40, 41, 42, 43, 44, 45, 46, 47,
54, 55, 56, 57, 58, 59, 60, 61, 62, 63,
70, 71, 72, 73, 74, 75, 76, 77, 78, 79,
86, 87, 88, 89, 90, 91, 92, 93, 94, 95,
102, 103, 104, 105
},
.oobfree = {
{2, 4}, {18, 4}, {34, 4}, {50, 4},
{66, 4}, {82, 4}, {98, 4}, {114, 4}
}
};
but our manual for a 4KiB Samsung OneNAND specifies
that each 512 byte sector has 16 bytes of OOB
0-1 bad block info
2-3 free
5-6 reserved
7-15 ecc
which implies ecc layout should be as follows for
4KiB pageOneNAND.
/**
* onenand_oob_128 - oob info for Onenand with 4KB page
* For now, we expose only 64 out of 72 ecc bytes
*/
static struct nand_ecclayout onenand_oob_128 = {
.eccbytes = 64,
.eccpos = {
7, 8, 9, 10, 11, 12, 13, 14, 15,
23, 24, 25, 26, 27, 28, 29, 30, 31,
39, 40, 41, 42, 43, 44, 45, 46, 47,
55, 56, 57, 58, 59, 60, 61, 62, 63,
71, 72, 73, 74, 75, 76, 77, 78, 79,
87, 88, 89, 90, 91, 92, 93, 94, 95,
103, 104, 105, 106, 107, 108, 109, 110, 111,
119
},
.oobfree = {
{2, 3}, {18, 3}, {34, 3}, {50, 3},
{66, 3}, {82, 3}, {98, 3}, {114, 3}
}
};
Do 4KiB OneNANDs need a different onenand_oob_128 from
FlexOneNAND?
Regards
Adrian
next prev parent reply other threads:[~2011-01-27 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 9:49 4KiB page OneNAND OOB Adrian Hunter
2011-01-27 9:59 ` Kyungmin Park [this message]
2011-01-27 11:10 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0a2301cbbe08$ea2d8a60$be889f20$%park@samsung.com' \
--to=kyungmin.park@samsung.com \
--cc=adrian.hunter@nokia.com \
--cc=kmpark@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=roman.tereshonkov@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).