From: <Tudor.Ambarus@microchip.com>
To: <vincent@systemli.org>, <linux-mtd@lists.infradead.org>
Cc: <mail@david-bauer.net>
Subject: Re: [PATCH 2/2] mtd: spi-nor: disable 16-bit-sr for macronix
Date: Wed, 29 Dec 2021 14:08:47 +0000 [thread overview]
Message-ID: <0db13110-ee6f-2e02-abf9-d5b9eecafcb4@microchip.com> (raw)
In-Reply-To: <20211227091638.177917-2-vincent@systemli.org>
On 12/27/21 11:16 AM, vincent@systemli.org wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Nick Hainke <vincent@systemli.org>
>
> Macronix flash chips seem to consist of only one status register.
> These chips will not work with the "16-bit Write Status (01h) Command".
> Disable SNOR_F_HAS_16BIT_SR for all Macronix chips.
Hi, Vincent!
Have you checked all the existing macronix flash_info entries and determined
that neither of them support SNOR_F_HAS_16BIT_SR? Per manufacturer settings
are a bit sensible because we can't predict what manufacturers are doing with
new flash designs and whether they'll respect their "legacy" flash settings or
not. Thus I'm a bit reluctant in adding per manufacturer settings.
Cheers,
ta
>
> Tested with MX25L6405D.
>
> Fixes: 39d1e3340c73 ("mtd: spi-nor: Fix clearing of QE bit on
> lock()/unlock()")
>
> Signed-off-by: David Bauer <mail@david-bauer.net>
> Signed-off-by: Nick Hainke <vincent@systemli.org>
> ---
> drivers/mtd/spi-nor/macronix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
> index f07b59a4120a..d530ab0b3b13 100644
> --- a/drivers/mtd/spi-nor/macronix.c
> +++ b/drivers/mtd/spi-nor/macronix.c
> @@ -94,6 +94,7 @@ static void macronix_default_init(struct spi_nor *nor)
> {
> nor->params->quad_enable = spi_nor_sr1_bit6_quad_enable;
> nor->params->set_4byte_addr_mode = spi_nor_set_4byte_addr_mode;
> + nor->flags &= ~SNOR_F_HAS_16BIT_SR;
> }
>
> static const struct spi_nor_fixups macronix_fixups = {
> --
> 2.34.1
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-12-29 14:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 9:16 [PATCH 1/2] mtd: spi-nor: locking support for MX25L6405D vincent
2021-12-27 9:16 ` [PATCH 2/2] mtd: spi-nor: disable 16-bit-sr for macronix vincent
2021-12-29 14:08 ` Tudor.Ambarus [this message]
2021-12-31 9:10 ` Nick
2021-12-31 9:50 ` Nick
2022-01-19 15:49 ` Michael Walle
2022-01-19 20:36 ` David Bauer
2022-01-20 8:08 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0db13110-ee6f-2e02-abf9-d5b9eecafcb4@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=linux-mtd@lists.infradead.org \
--cc=mail@david-bauer.net \
--cc=vincent@systemli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox