From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5100CC433F5 for ; Wed, 27 Apr 2022 07:11:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xjzj53ZO9ReeGY5eY/bmQDxowyAkM1lqOS9n1+GttAA=; b=HobVT2Kr1a4hhN L3Wg3A6w9txs9PxkL/FjsYnnyRg9oNGZdYR9d8Ei5AF3rqVyjiSVPWeq5dQbfNpFMTdkdRZpqJFY/ vYAj8pSE6nooXmqbUX/0viik5Rb8TKiHFzt/O5uOz3bY7/sEsiOyNRDLDH2h9qB5X6zKtmaGJAxP1 Ne4PdYpA43u8zxaFZyR+T74HI1BXIvGVTF9QJHeIrVtRjjNIhjMmc0LAf9r+XaSeYgeOVuazqcedM 19OiBlbDn9ULOQub1p1X1Bg2HatNcMRt1qaj4Yv3+vxAfrzOaW62G7CbZcJpcwI5PvFP1hOfdNcaj Y5pDIsw6gaFq9jCKHeLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njbpq-000Bzs-Qm; Wed, 27 Apr 2022 07:11:38 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njbpm-000Bwl-Pe for linux-mtd@lists.infradead.org; Wed, 27 Apr 2022 07:11:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1651043494; x=1682579494; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=KmvKo+F4mMPzonJJHO2HRNnJTTjFrOLIXaiW32/xVDw=; b=Klge6kyJytlZV80CE1pwdkxDs/vf4mCBJhcCR5asakA3To3fuvJ0F5YK caopspYknkoA0ajxcvj/HOszACLdHERaXHT3wQNJGN35GGKoX4TtvuWRw /yW6jsHIs0JzKM4S8U6YNfZvMQL7RSw/jYbOjisj1jLfZ1Jpwj95zv7AR eXdCUDkCeW4BKrQYNrEOmy6F5mIXzQ/yElTGmi7QwcIWOG8QQas8arVac AJYgGpq3BvKeyggncvS3R8gg2faHLF3TCwp7gtAWm5JARNh/H3K3EN8hk JTHo4ZvbHj2hsBy85Lyi8TJyW/glwybBaLEkckeHJTNI0LXFn6KCxJrK3 g==; X-IronPort-AV: E=Sophos;i="5.90,292,1643698800"; d="scan'208";a="156935531" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 27 Apr 2022 00:11:32 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 27 Apr 2022 00:11:32 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17 via Frontend Transport; Wed, 27 Apr 2022 00:11:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gYdmH8syslnU2goojhykMGOsD/bt6LBPTfShi3Xj2CLN5ypEHSXwrWJGUcjIpAgnZCAjQzVmoKwTexhFIvwF/jdL0w5LJ5a/XPPNEr05mD/FqUOy/i5EF78HxAtLEHJsm6kEQv/skPcYJfCyFvSPBM7gk6FskqEy0Ks4mm2OYuMOu95YGiDkPBzPAyVUtsI5x/Ctl36UT81h1M1wYZtHnIMd4RuLQi4Mc8Cs1GpWaJpiC22u0fuuPdSPQ69S+j+AoXo613WmvbLrXSc8e6eRELybFCnGe9phLHai3Gp2X7+EKhtQCj/g0+5C2p/Sdvrt0CX4AO5O3BAk5lP/5rbpfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KmvKo+F4mMPzonJJHO2HRNnJTTjFrOLIXaiW32/xVDw=; b=GZiYwljMRRzVfL3qcGp7sRFIG6wZLpRAIbM0XdwjdsRZPS4DbF35JJmgfkbbnxLi2Ksctt79usq/AiXSHv87/VMMbW1IImE11rzRUAIPImWbMJzB8E91gs5ktaQygCfuSLanBmxEfcZKk+62Kh5fqron7i+HajljdpGwi0xxI+LkmTCQjhjeH4TpNn1ovlRg79Xe2I2pZshxGbnfIDfLj/UO8bTtpieKjrTjz40fn7mGSJ6EI4qd59N4ZG2WOJIEFK3nfWn1zS2FfKl2AjuR529nUQtHmWr8xx0a/2wvoH29DYqoL5xIxUN+YZTqjaYtiRT6UaXaz55Oi/1+GR8Gsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KmvKo+F4mMPzonJJHO2HRNnJTTjFrOLIXaiW32/xVDw=; b=iUCctvBq2H/MPhm/WAN8rjuTQRIjKYj4YGfAd1zhnOnxns/kIwSd3m8V0E52/nOXYvs0gFdxXMPn490i8rbVUUafaRdJqmxLFjet9iyNLHNxV4zwDAKH/mr893C20ub5WBSLo18xYrWq/3r+9BvvUXsv3WnpWu6pwsxuPm/OerA= Received: from SA2PR11MB4874.namprd11.prod.outlook.com (2603:10b6:806:f9::23) by CY4PR11MB2056.namprd11.prod.outlook.com (2603:10b6:903:30::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Wed, 27 Apr 2022 07:11:18 +0000 Received: from SA2PR11MB4874.namprd11.prod.outlook.com ([fe80::2447:4025:79e6:7c08]) by SA2PR11MB4874.namprd11.prod.outlook.com ([fe80::2447:4025:79e6:7c08%5]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022 07:11:18 +0000 From: To: , CC: , , , , , Subject: Re: [RESEND PATCH] mtd: spi-nor: core: Check written SR value in spi_nor_write_16bit_sr_and_check() Thread-Topic: [RESEND PATCH] mtd: spi-nor: core: Check written SR value in spi_nor_write_16bit_sr_and_check() Thread-Index: AQHYWgX8ewfNtQDrSE2YBtaW8mA4Jg== Date: Wed, 27 Apr 2022 07:11:18 +0000 Message-ID: <0e02112a-317c-e95b-e0d3-7ed2c74c3509@microchip.com> References: <20220126073227.3401275-1-chentsung@chromium.org> <20220131171929.uk3z5sr453c3eefp@ti.com> In-Reply-To: <20220131171929.uk3z5sr453c3eefp@ti.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1f4db88e-4ecf-4298-3883-08da281d2007 x-ms-traffictypediagnostic: CY4PR11MB2056:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: av08BLUuOFEk6HFx8YiZ79bQqp0giuJ7Vvl++O1LAjymHCRoGsAkXqjtgRvMFR3bv6tUbDkGGf/9HHVJl4PaYbBD1CgirsX7TiY6iFiCrFSnm5P3lLBPhlNvsXADfzrhPJb5DOlwtZfDgmYtuxwcl0sNVaBmTzQmKOdeHeIjnwg8/ucbf0SnWjpOOELfVMUd8FbpmK3zehFUWXgu5eFcPcftqfHBHGiGZq0v7nGUcQ25Dc1qJfzHsV2Bt+kK0hMnaoDJhRos3/cPvamnh/RBshmpVR7/rjleYXpCLxp7i2NMoecGKtZqhTZDSkJZ2TStR/XJsP0x49wF78eVAEQ+4fAbbJM7GJrmnDIjPmKPvnfWCq066eQTTmxzhcX9OvYfwm0dClD14XqwEGwDTUP+ZPRSDm4bNkLddDfQGnQYORCoGVjW9s0zTGXWbdobM+alDSihrYDN18bFdLabDNy4fB8mlGfXt5jfBYH3ya0iXhDjLUeVNtV3pZJJjUlEOIb9kSaMUkA96bhhptRux3CmU4N92MhoGnKzo90eFXlHypt8r7deGkvTnYIV+jfX/A5P9UJMNlXAe2aq/O6FQ4P4VhEjcKJ6pbokjXH6v0xbFauMd3g8N27GO7c/3ereRXpSPerRqkzjVKoeaKU/UAmiP7hIZF6GSyZukgXKt5ARTUN/SEIZUIMk9JkgEmXHdCHFrIEFPP6setz+OyS6j0RLrYFFGgPJZ5MIw3ZI7EXKn7iBaCPxvu2ierNHiBt9fmL5AVuybfnAuIQkXAGzPlM2jw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR11MB4874.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2616005)(66946007)(5660300002)(6512007)(91956017)(122000001)(8936002)(66446008)(66556008)(4326008)(76116006)(316002)(26005)(4744005)(38100700002)(86362001)(31696002)(38070700005)(2906002)(508600001)(6486002)(71200400001)(64756008)(8676002)(66476007)(83380400001)(186003)(53546011)(110136005)(6506007)(31686004)(36756003)(54906003)(45980500001)(43740500002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YzVwRjlyUytoYkZDZHpJazNtdExMdWdSNk04dUJjSkVPTjhseCtwcC9ESkh3?= =?utf-8?B?cjBkVUFIeEh2cUdYOFNadGpEZTVUWjBCK3VQcDViRnVKMGFubmJIOFpzcHds?= =?utf-8?B?M2NPNjlPNkw5dEh2ZjMyeTl0MFRQajQ1NG00RVBBeEZjV1g4VVp4VXN1eU5Y?= =?utf-8?B?RldNRzh3cWpKMGNCY2Zyclo0eWRnczJ5cHRjRkw4a2M1MGNSaVZBaFVIb0hR?= =?utf-8?B?MjlyUWo1eDB5b05UV0V0MlpSTzdqdWJybFI5bk1xNGw4N0NpUEQweWFjQm94?= =?utf-8?B?YU50UFBSaXZoSUNpdFNlMEVrV0ZEODI1Y1VTd05iQkdzZHJ3dmVvaitISWpp?= =?utf-8?B?YldET21MZnZQNDEzcGVlMngrdDZaSWxCbzhwczAwbUhhOFBEL0xEditwK0g0?= =?utf-8?B?czNiL2EwcmJ1Vnk5bzUzOFBWbTRRV1Q2Znc4S1E4ZU8vbm5JM1V3NmZBaCtT?= =?utf-8?B?WXpjbnBnWUpXRDYrMmJBak1TWGU3c2pGeENEQ0Y2YVVxMDRuZXFhLzFJTWZE?= =?utf-8?B?RjZza0R0VXcrOU0wUExtRWd6T1hNRWZuV3pRbXdRUVh5aVc1dkdQN1hRMURw?= =?utf-8?B?RHoyN3IxZGNhdFptd1NMNUxuMmY5WEZ3SFBqUkNYRlNiaE8yK3BGOG5vd0ph?= =?utf-8?B?NlpJTHd5bEVwa2VCQ1pRQmJLUHdrSXNxNWtTL0RwRGdiTGRKajVJTG9MRDMx?= =?utf-8?B?Uk1adFNJZ2lhSC9LYm52S3JTeGVxZlZFSUtqRThNWVk5VlFhNk52VjBkL0lL?= =?utf-8?B?T05rdEdJK2diRlBERXEwTGk2L3Bsa2F4NmdJdVUyU1lkTTBWdkNuUVMwM05p?= =?utf-8?B?RUZtcEtIQ0N4OUUvNmxncVM5bnlZb0Rya2VHVTlNQlM1VlpLaXBNL0dzYnNO?= =?utf-8?B?NWFZdmJHOS84eW4zd1pPYy9JVDlmeCtmRGx0ZmZWbG9jc2VxNmRJOXJyajM3?= =?utf-8?B?dldnNXZueDFCUXlUWm1BVTNRVlhLZVphSWx2VWdwanZVelJPQitKVFdDZkxu?= =?utf-8?B?c2hod3JCRGQrUXJIWnFlaXY0SGxWUm81RFhSN2d6QjJUSGo5OGRWTHpoZFRK?= =?utf-8?B?UE9jZGxXOWJTTmU3QnJncE5VTHg4UmhUZkNvWmpiVEVMS0tiL2ptNW8yYktj?= =?utf-8?B?NUV2L2hMQVJPaTRWVXFlWExUU3kyallwaDNuTWdkUmY4OUR3TDh6VkZWbnRy?= =?utf-8?B?S1duTVJab3haenkxajVVcXVXT1dNNUw1Q0ZKRUVQaTZZUzk5NHpmYWNmZ2N4?= =?utf-8?B?WFN3NkxXUnllM2FQUWdGdm5VUGlDbE1YSmFmcG4vWXplZGh3MXpsbEY1K3J2?= =?utf-8?B?alo3NVNpMnlqZG0zbC9pZFJVaE9rclVDUU5TTmQwRS9lRjRtQm1ZRjBMcDIw?= =?utf-8?B?SUtsWkZUWXBkTVpMMk5DMDVvbXd0MHRzV0lUcnpVOFU0cmxlNzIrTzRWeXJR?= =?utf-8?B?dFZkVW1vTHhZVXR2bU9UNzhzTTFOVDJpWGUvZC9hSmx5elpjNTZKYXcyb1JU?= =?utf-8?B?QjhGOWhteThqTmVBWkl5Z2RZWWJueTNES1VsTmduZGoyRXRUMEx4aFNTbG03?= =?utf-8?B?cVFnRXV6V1ZIbnRESUtFVTBDcWY5WEhMenZCaDVXNW0vNjZXRG04S3FSVEJH?= =?utf-8?B?cTJNdFZCSTVRbmo3aFQyVlI4TEJuOVlRQ2FUcFFKZU90ZitFcGVRRHBYQy9N?= =?utf-8?B?c29ORHFQZHcwTFpEUDR4b3FxaytkR3ZwRlg3R1pDb3JXYXdyTVBzd2ZLcFVy?= =?utf-8?B?Nms5bXV0MWNMRUhpbTJlZHBLTFB5eDU4Y3VscUFzWm9pZ1VCOGpVWFZVRm5k?= =?utf-8?B?aTFkVlliR3lFU0Nhb1ZpR005U0NQaWdFNWtUcUtEeXFJNElYZ1E4U1UwTm9K?= =?utf-8?B?cncweDdFTmc4eVF4T3dlemZRZDFNU0RheldkOXJreXNFOW9yMTV1VTE2amNQ?= =?utf-8?B?UWs5b3ZBTFNxVGlUSTdJaGlBM1VmelRobDN3eWxJZlEvTFBvbVNNaHM1OVFu?= =?utf-8?B?ZDZhaDhiVWlwTTVjTHdUV0wya0cwSWh2dXEvWUd6VVI5c3lsZVN4TlJyRElt?= =?utf-8?B?STNjL2hVS1NuaERlaXFXRXFHdXBrN3ROZE5pM251RytzVmI1NzVZUzVOMEUx?= =?utf-8?B?UkdzbmJXNGFPTkJtUEtvQXlMN0NWeWhQQXZKK2Y1M0hRbENXS05HVnNQdnE0?= =?utf-8?B?dW1aeERlMlpMUWlYRDJrQkNDWmtMMHFrM2dLYW9VWEhWUUFpc0lQaWNFVFZl?= =?utf-8?B?VWV2VWF3ZlpObThKK1JERWQrRmZwaVkvc1IxNVlDSU9jU3NlTlIybU5tbEIw?= =?utf-8?B?cXBpRFJZaUV0ZkwwbE9ZYkxFS0xScXBXOW1QOVU4V3R6TCtEQ2p3bWI3R1Bi?= =?utf-8?Q?zUjtIZuU6i/luKuw=3D?= Content-ID: <716906425AB4A04CAF7F9928260FA1B9@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB4874.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f4db88e-4ecf-4298-3883-08da281d2007 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 07:11:18.2227 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iqerdtLHbKhPsF2QBDcmHNmIlAPp4l9UhanVSWl4zA1Xs1EjAjPT9XbTPu/xOym/4YvDy0WlmS3gf8x07qe1qS/txCa1xGRfP4JCPez+j0M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB2056 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220427_001135_161780_617B6FC5 X-CRM114-Status: GOOD ( 12.20 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 1/31/22 19:19, Pratyush Yadav wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 26/01/22 03:32PM, Chen-Tsung Hsieh wrote: >> Read back Status Register 1 to ensure that the written byte match the >> received value and return -EIO if read back test failed. >> >> Without this patch, spi_nor_write_16bit_sr_and_check() only check the >> second half of the 16bit. It causes errors like spi_nor_sr_unlock() >> return success incorrectly when spi_nor_write_16bit_sr_and_check() >> doesn't write SR successfully. >> >> Fixes: 39d1e3340c73 ("mtd: spi-nor: Fix clearing of QE bit on lock()/unlock()") >> Signed-off-by: Chen-Tsung Hsieh > > I don't know much about this bit of code but this patch looks fine to me > from the surface. Would be nice to hear from Tudor about this too since > he added the function. Reviewed-by: Tudor Ambarus > > Acked-by: Pratyush Yadav ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/