Re: [PATCH] mtd: spi-nor: XTX: Add support for XTX XT25F128B

From: <Tudor.Ambarus@microchip.com>
To: <macromorgan@hotmail.com>
Cc: <linux-mtd@lists.infradead.org>, <vigneshr@ti.com>,
	<andreas@rammhold.de>,  <figgyc@figgyc.uk>, <richard@nod.at>,
	<miquel.raynal@bootlin.com>
Subject: Re: [PATCH] mtd: spi-nor: XTX: Add support for XTX XT25F128B
Date: Mon, 28 Jun 2021 05:56:03 +0000	[thread overview]
Message-ID: <0eb12da2-72f7-0c12-e03c-ea152e37336b@microchip.com> (raw)
In-Reply-To: <SN6PR06MB5342947DCCA76AB0F4EF27BBA5779@SN6PR06MB5342.namprd06.prod.outlook.com>

Hi, Chris,

On 4/5/21 10:16 PM, Chris Morgan wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Mon, Apr 05, 2021 at 08:52:11AM +0000, Tudor.Ambarus@microchip.com wrote:
>> Hi,
>>
>> On 4/2/21 11:15 PM, Chris Morgan wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> Add support for a new vendor (XTX) along with a new chip from the
>>> vendor (XT25F128B). This chip is used in the Odroid Go Advance,
>>> and has been tested extensively using the spi-gpio driver, as it
>>> is connected to a serial flash controller that is not currently
>>> supported (but the pins can be repurposed to GPIO). Read, write, and
>>> erase all work as expected.
>>>
>>> Datasheet can be found here:
>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdatasheet.lcsc.com%2Fszlcsc%2F2005251034_XTX-XT25F128BSSIGT_C558844.pdf&amp;data=04%7C01%7C%7Cf7133c0ccefc4898050e08d8f8101c7d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637532095378348815%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=SgseEt9ZbY%2BIaZdMyKLTAh3rnD5zrVqJYV3d0jAt6qM%3D&amp;reserved=0
>>>
>>> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
>>
>> Chris, we're trying to figure out how to deal with the continuation codes.
>> Discussions on going at:
>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flkml.org%2Flkml%2F2021%2F2%2F7%2F223&amp;data=04%7C01%7C%7Cf7133c0ccefc4898050e08d8f8101c7d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637532095378353805%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=UJW6JeEVwwzttJ7CfhAOqGAzV%2FPyBJf%2FjWYvw6%2BUwuk%3D&amp;reserved=0
>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.spinics.net%2Flists%2Fkernel%2Fmsg3808260.html&amp;data=04%7C01%7C%7Cf7133c0ccefc4898050e08d8f8101c7d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637532095378353805%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=wyMehux468x49Nb%2FhypiKif9rztptk9CJuRWmBzZ0Og%3D&amp;reserved=0
> 
> Thanks, this helps.  For what it's worth, I ran the same command (spincl) on
> my Raspberry pi against this chip and came up with the following:
> 
> spincl -ib -m0 -c0 -s0 -p0 6 0x90
> 0x00 0x00 0x00 0x00 0x0b 0x17
> 
> spincl -ib -m0 -c0 -s0 -p0 4 0x9F
> 0x00 0x0b 0x40 0x18

I haven't checked what this spincl tool is doing. Would you please instead
hack the spi-nor core and read 15 bytes let's say, and just dump them with a dev_err?

> 
> Doesn't look like this one uses continuation codes either, sadly.
> Let me know what information I can provide to help with the
> continuation codes for these seemingly non-conformant chips.

Does this flash has a vendor table? We can get the bank number from the vendor's
table, Parameter ID field.

Michael has recently added support to dump the SFDP tables via sysfs.
Would you please dump the SFDP tables and post it here?

Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/