From: Florian Fainelli <florian.fainelli@broadcom.com>
To: "Michael Walle" <michael@walle.cc>,
"AceLan Kao" <acelan.kao@canonical.com>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Pratyush Yadav" <pratyush@kernel.org>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Dhruva Gole" <d-gole@ti.com>,
linux-mtd@lists.infradead.org, "Mark Brown" <broonie@kernel.org>,
"Kamal Dasu" <kamal.dasu@broadcom.com>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Mario Kicherer" <dev@kicherer.org>,
"Chuanhong Guo" <gch981213@gmail.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/2] spi: Unify error codes by replacing -ENOTSUPP with -EOPNOTSUPP
Date: Wed, 13 Mar 2024 10:13:43 -0700 [thread overview]
Message-ID: <0fad2eb5-34cd-4928-9e54-104c77de1424@broadcom.com> (raw)
In-Reply-To: <CZSQTVDX6QR1.1K5UGJUNPLM0S@walle.cc>
[-- Attachment #1.1: Type: text/plain, Size: 953 bytes --]
On 3/13/24 08:56, Michael Walle wrote:
> Hi,
>
> I just had a quick look to see where Florians breakage could come
> from and just noticed this:
>
>> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
>> index 849ccfedbc72..e0b6715e5dfe 100644
>> --- a/drivers/mtd/nand/spi/core.c
>> +++ b/drivers/mtd/nand/spi/core.c
>> @@ -974,7 +974,7 @@ static int spinand_manufacturer_match(struct spinand_device *spinand,
>> spinand->manufacturer = manufacturer;
>> return 0;
>> }
>> - return -ENOTSUPP;
>> + return -EOPNOTSUPP;
>> }
>>
>> static int spinand_id_detect(struct spinand_device *spinand)
>
> This seems to be random as no other spi-nand ENOTSUPP was converted
> but just this. Is there a reason for this, AceLan?
FWIW, we do not have any SPI-NAND flashes on those boards only SPI-NOR,
just posted a fix for this:
https://lore.kernel.org/r/20240313171050.3505620-1-florian.fainelli@broadcom.com
--
Florian
[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2024-03-13 17:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 6:43 [PATCH v7 1/2] spi: Unify error codes by replacing -ENOTSUPP with -EOPNOTSUPP AceLan Kao
2023-11-29 6:43 ` [PATCH v7 2/2] mtd: spi-nor: Stop reporting warning message when soft reset is not suported AceLan Kao
2023-11-29 7:46 ` Tudor Ambarus
2023-11-29 21:19 ` Mark Brown
2023-11-30 2:27 ` AceLan Kao
2023-11-30 9:20 ` Tudor Ambarus
2023-11-29 8:40 ` Miquel Raynal
2023-11-29 7:05 ` [PATCH v7 1/2] spi: Unify error codes by replacing -ENOTSUPP with -EOPNOTSUPP Mika Westerberg
2023-11-29 7:38 ` Tudor Ambarus
2023-11-29 8:28 ` Michael Walle
2023-11-29 8:39 ` Miquel Raynal
2023-11-30 14:19 ` Mark Brown
2024-03-13 15:40 ` Florian Fainelli
2024-03-13 15:56 ` Michael Walle
2024-03-13 17:13 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fad2eb5-34cd-4928-9e54-104c77de1424@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=acelan.kao@canonical.com \
--cc=broonie@kernel.org \
--cc=d-gole@ti.com \
--cc=dev@kicherer.org \
--cc=gch981213@gmail.com \
--cc=j.neuschaefer@gmx.net \
--cc=kamal.dasu@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=michael@walle.cc \
--cc=mika.westerberg@linux.intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox