From: Thomas Gleixner <tglx@linutronix.de>
To: Ken Offer <koffer@arlut.utexas.edu>
Cc: LinuxMTD <linux-mtd@lists.infradead.org>
Subject: Re: Found ecc verify bug in nand.c
Date: Sat, 17 Aug 2002 10:16:31 +0200 [thread overview]
Message-ID: <1029571384.2142.19.camel@thomas.tec.linutronix.de> (raw)
In-Reply-To: <0BBECB8C-B15D-11D6-BE50-000393467F1A@arlut.utexas.edu>
On Fri, 2002-08-16 at 23:13, Ken Offer wrote:
> This is a compare to see if the ecc has changed. Unfortunately,
> data_buf is UNSIGNED char and ecc_code is SIGNED char. When
> compiling under gcc 2.95.3 on a powerpc system, the code ends up
> comparing two identical bytes and fails because one is
> sign-extended (example: comparing 0xc3 becomes "0xc3 ==
> 0xffffffc3"). I don't know if this makes a difference with the
> x86 compiler, but it does under powerpc.
It's a problem on other arch's too. It did not happen to me, because I
don't use the NAND_WRITE_VERIFY paranoia check :)
Thanks, fixed in CVS
--
Thomas
____________________________________________________
linutronix - competence in embedded & realtime linux
http://www.linutronix.de
mail: tglx@linutronix.de
prev parent reply other threads:[~2002-08-17 8:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-16 21:13 Found ecc verify bug in nand.c Ken Offer
2002-08-17 8:16 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1029571384.2142.19.camel@thomas.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=koffer@arlut.utexas.edu \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox