From: Raphael Hertzog <eng@eipm.ch>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: NFTL not recognizing disk on chip in some cases
Date: 30 Jan 2003 11:56:26 +0100 [thread overview]
Message-ID: <1043924186.9795.26.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.44.0301300819250.4791-100000@imladris.demon.co.uk>
Am Don, 2003-01-30 um 09.19 schrieb David Woodhouse:
> On 30 Jan 2003, Raphael Hertzog wrote:
>
> > I'm happy to test any patch since I can reproduce the problem here very
> > regularly ... :-)
>
> Index: drivers/mtd/nftlmount.c
> ===================================================================
> RCS file: /home/cvs/mtd/drivers/mtd/nftlmount.c,v
> retrieving revision 1.31
> diff -u -p -r1.31 nftlmount.c
> --- drivers/mtd/nftlmount.c 15 Nov 2002 16:34:43 -0000 1.31
> +++ drivers/mtd/nftlmount.c 30 Jan 2003 08:19:46 -0000
> @@ -137,7 +137,11 @@ static int find_boot_record(struct NFTLr
> printk(KERN_NOTICE "NFTL Media Headers at 0x%x and 0x%x disagree.\n",
> nftl->MediaUnit * nftl->EraseSize, block * nftl->EraseSize);
> /* if (debug) Print both side by side */
> - return -1;
> + if (boot_record_count < 2) {
> + /* We haven't yet seen two real ones */
> + return -1;
> + }
> + continue;
> }
> if (boot_record_count == 1)
> nftl->SpareMediaUnit = block;
Ok. It effectively fixes the problem. It's not very nice since the
notice is still displayed ... but that doesn't matter much.
Thanks for the patch !
Cheers,
--
Raphaël Hertzog - EIPM SA
next prev parent reply other threads:[~2003-01-30 10:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-29 12:47 NFTL not recognizing disk on chip in some cases Raphael Hertzog
2003-01-29 14:48 ` Henrik Nordstrom
2003-01-29 16:42 ` Raphael Hertzog
2003-01-29 17:05 ` Henrik Nordstrom
2003-01-29 18:30 ` Mark Meade
2003-01-29 22:41 ` David Woodhouse
2003-01-30 8:05 ` Raphael Hertzog
2003-01-30 8:19 ` David Woodhouse
2003-01-30 10:56 ` Raphael Hertzog [this message]
2003-01-30 10:14 ` Raphael Hertzog
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1043924186.9795.26.camel@localhost \
--to=eng@eipm.ch \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox