Re: [PATCH RFC] 1/2 central workspace for zlib

Jörn Engel
2003-06-02T15:53:25Z

On Mon, 2 June 2003 16:40:07 +0100, David Woodhouse wrote:
>
> mtdblock shouldn't actually be _using_ the vmalloc'd buffer for write
> caching in production at all. Anyone using mtdblock in write mode for
> production wants shooting.

Or any other form of lart.

> Perhaps we could get away with allocating it only when the device is
> opened for write? Even that's suboptimal since in 2.4, JFFS2 opens the
> mtdblock device for write but doesn't actually _write_ to it; just gets
> the appropriate MTD device and uses that directly.

Maybe lazy allocation. vmalloc() it with the first write(), which
should be never in production use. So the extra overhead doesn't
really matter.

Do you mind if I submit such a patch?

Jörn

--
Correctness comes second.
Features come third.
Performance comes last.
Maintainability is needed for all of them.