Re: Handling multiple NAND chips

David Woodhouse
2003-07-27T13:43:18Z

On Sun, 2003-07-27 at 08:54, J.D. Bakker wrote:
> What is the return value for select_chip supposed to be ? Current CVS
> is a bit ambiguous in this regard (understandably, considering the
> newness).

Currently void -- I can't imagine cases where it could fail. I suppose
I'll probably turn out to be wrong though...

> Style question: unsigned char, __u8, u_char, u_int8_t or uint8_t ?
> The kernel part of CVS uses all five in different places.

unsigned char, uint8_t and u_char are the only ones I'd want to see --
and the latter only if it's already in use. One of the former two in new
code, please -- preferably 'unsigned char' I think.

I reserve the right to do otherwise, and to change my mind -- not
necessarily in that order.

--
dwmw2