From: David Woodhouse <dwmw2@infradead.org>
To: gdavis@mvista.com
Cc: linux-mtd@lists.infradead.org
Subject: Re: kernel oops due to aligment error in cmdlinepart.c
Date: Fri, 01 Aug 2003 14:24:11 +0100 [thread overview]
Message-ID: <1059744249.19396.75.camel@lapdancer.baythorne.internal> (raw)
In-Reply-To: <3F29AE2C.2020000@mvista.com>
On Fri, 2003-08-01 at 01:02, George G. Davis wrote:
> Greetings,
>
> I've been using the latest MTD CVS (+/- a few days) on an ARM
> Integrator/CM920T running linux-2.4.20'ish and have found that
> cmdlinepart.c has a struct alignment problem which causes a kernel
> oops. The attached patch fixes the alignment problem
No Likee. Linux requires that you fix up misaligned loads and stores.
Therefore, explicit working around alignment 'breakage' isn't permitted.
I've added it before and been told to remove it.
IF your hardware _cannot_ do this, and I know some ARM7 uCLinux systems
really can't, then you need to deal with it properly in 2.5 -- talk to
DaveM and Linus about it.
Alternatively, in this case you could probably just refactor the code to
allocate the idents separately or at least arrange its storage so that
the aligned bits are first, like I think the RedBoot code does.
--
dwmw2
prev parent reply other threads:[~2003-08-01 13:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-01 0:02 kernel oops due to aligment error in cmdlinepart.c George G. Davis
2003-08-01 13:24 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1059744249.19396.75.camel@lapdancer.baythorne.internal \
--to=dwmw2@infradead.org \
--cc=gdavis@mvista.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox