public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: "Øyvind Harboe" <oyvind.harboe@zylin.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: RFC - patch to reduce peak memory usage by disabling compression
Date: Thu, 21 Aug 2003 13:44:59 +0100	[thread overview]
Message-ID: <1061469898.13830.52.camel@hades.cambridge.redhat.com> (raw)
In-Reply-To: <002601c367e0$2da6b0a0$73dea8c0@lair>

On Thu, 2003-08-21 at 14:31 +0200, Øyvind Harboe wrote:
> Reduce RAM usage by removing compression/decompression altogether.

You could make it use a static buffer and serialise compression, and it
really would be only 4KiB you're saving.

I sincerely hope this is done because you're using uncompressible data,
rather than trading about 4KiB of cheap RAM for a doubling in expensive
flash space :)

If you're doing this, I'd prefer to change jffs2_compress() to allocate
its _own_ buffer (or optionally use a static one), then have a simple
definition of jffs2_compress which does nothing in the
!CONFIG_JFFS2_FS_COMPRESSION case. 

You need to handle the case where compression is configured out and a
filesystem created with compressed nodes is encountered -- it looks like
it'll die horribly at the moment.

I'd also like to see individual compression routines selectable, and
also at runtime with something akin to chattr.

-- 
dwmw2

  reply	other threads:[~2003-08-21 12:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-21 12:31 RFC - patch to reduce peak memory usage by disabling compression Øyvind Harboe
2003-08-21 12:44 ` David Woodhouse [this message]
2003-08-21 13:00   ` RFC - patch to reduce peak memory usage by disablingcompression Øyvind Harboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1061469898.13830.52.camel@hades.cambridge.redhat.com \
    --to=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=oyvind.harboe@zylin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox