Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Tokarev <annulen@yandex.ru>
To: Elie De Brauwer <eliedebrauwer@gmail.com>,
	"motobud@gmail.com" <motobud@gmail.com>,
	"dedekind1@gmail.com" <dedekind1@gmail.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH v0] mkfs.ubifs: Add support for lz4hc compressor in mkfs.ubifs
Date: Sat, 05 Oct 2013 15:53:23 +0400	[thread overview]
Message-ID: <106341380974003@web15m.yandex.ru> (raw)
In-Reply-To: <1380956001-6122-1-git-send-email-eliedebrauwer@gmail.com>



05.10.2013, 10:53, "Elie De Brauwer" <eliedebrauwer@gmail.com>:
> Brent et all,
>
> I was bored last night and while following the thread on the lz4hc
> compression for ubifs got my attention so I decided to give a go at
> implementing in. Below you can find a patch which does just that.
>
> An lz4hc and favor_lz4hc compr type, they mimick lzo and favor_lzo
> but use lz4hc instead of lzo.
>
> In order to use lz4hc I included 3 files from the lz4 project since
> lz4 is not yet available in a conventient modular form (suggestions
> to fix this are welcome).
>
> In the meantime I saw however that Brent was also considering adding
> lz4hc support mkfs.ubifs so I'm making a v0 zero post either to serve
> as input for review comment (mainly on handling the lz4 dependency)
> and then I'll take care of cleaning up and testing it myself, or just
> to serve as some reference to the implementation of Brent, let me know
> of you want some polishing up on this version or are already in an
> advanced phase of a solution of yourself.
>
> (Yes, it's called v0, it's still untested but I would like input on
> the lz4 dependency handling and the extension of the options, or
> do we see something feasible where we contain lzo/lz4hc and zlib on
> the fly, suggestions welcome).
>
> my 2 cents
> E.

Thank you very much!

Unfortunately, your patch does not apply cleanly. I've tried mtd-utils
master and v1.5.0, and got rejects in both cases.

-- 
Regards,
Konstantin

  reply	other threads:[~2013-10-05 11:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-05  6:53 [PATCH v0] mkfs.ubifs: Add support for lz4hc compressor in mkfs.ubifs Elie De Brauwer
2013-10-05 11:53 ` Konstantin Tokarev [this message]
2013-10-05 12:56   ` Elie De Brauwer
2013-10-05 13:24     ` Konstantin Tokarev
2013-10-05 13:51       ` Konstantin Tokarev
2013-10-05 14:17         ` Konstantin Tokarev
2013-10-05 14:25           ` Elie De Brauwer
2013-10-05 14:17         ` Elie De Brauwer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=106341380974003@web15m.yandex.ru \
    --to=annulen@yandex.ru \
    --cc=dedekind1@gmail.com \
    --cc=eliedebrauwer@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=motobud@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox