patch and two questions

patch and two questions

[Ray Lehtiniemi]

hi all

i'm using the latest MTD CVS against arm linux-2.4.18-rmk1.


first a patch that seems to be needed:


Index: include/linux/mtd/compatmac.h
===================================================================
RCS file: /home/cvs/mtd/include/linux/mtd/compatmac.h,v
retrieving revision 1.33
diff -u -r1.33 compatmac.h
--- include/linux/mtd/compatmac.h	2002/03/02 22:08:26	1.33
+++ include/linux/mtd/compatmac.h	2002/03/02 23:21:26
@@ -489,7 +489,7 @@
 {
 	recalc_sigpending(current);
 }
-#define recalc_sigpending() __recalc_sigpending ()
+#define recalc_sigpending(c) __recalc_sigpending ()
 #endif
 
 #if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,5)




now, two questions:

i get the following compile warnings all over the place:

  /opt/dev/linux/src/linux/include/linux/mtd/compatmac.h:492: warning:
           `recalc_sigpending' redefined
  /opt/dev/linux/src/linux/include/linux/modules/signal.ver:24: warning:
           this is the location of the previous definition

should i be worried?



second, if i have a flash device which i want to partition, is it better
to use add_mtd_partitions() or use the approach taken by
mtd/drivers/mtd/maps/nora.c?  just looking at the code, they seem to
accomplish the same thing, correct?



thanks

-- 
---------------------------------------------------------------------------
    Ray Lehtiniemi <rayl@mail.com> <rayl@otii.com>

Re: patch and two questions

[David Woodhouse]

rayl@otii.com said:
> i'm using the latest MTD CVS against arm linux-2.4.18-rmk1.
> first a patch that seems to be needed:

That was correct. You need to remove the argument to recalc_sigpending() in 
the code itself. This is because of a change that happened in 2.5 - and the 
stuff in compatmac.h is to make it work again in 2.4.

I've just committed that change to mtdblock.c and blkmtd.c

--
dwmw2

Re: patch and two questions

[David Woodhouse]

rayl@otii.com said:
> second, if i have a flash device which i want to partition, is it
> better to use add_mtd_partitions() or use the approach taken by mtd/
> drivers/mtd/maps/nora.c?  just looking at the code, they seem to
> accomplish the same thing, correct? 

They do the same thing. Nora.c was written before the generic partition 
stuff existed. Use add_mtd_partitions.

--
dwmw2