* TRIVIAL: Fix linux/mtd/nftl.h for user-space inclusion
@ 2004-06-01 20:15 Bernardo Innocenti
2004-06-01 20:29 ` David Woodhouse
0 siblings, 1 reply; 6+ messages in thread
From: Bernardo Innocenti @ 2004-06-01 20:15 UTC (permalink / raw)
To: linux-mtd
Fix linux/mtd/nftl.h for user-space inclusion (required to build mtd-utils).
Please apply.
--- linux-2.6.6-uc0/include/linux/mtd/nftl.h 2004-05-10 04:33:13.000000000 +0200
+++ linux-2.6.6-uc0-develer/include/linux/mtd/nftl.h 2004-06-01 22:03:36.824225250 +0200
@@ -8,7 +8,6 @@
#define __MTD_NFTL_H__
#include <linux/mtd/mtd.h>
-#include <linux/mtd/blktrans.h>
/* Block Control Information */
@@ -76,6 +75,8 @@
#ifdef __KERNEL__
+#include <linux/mtd/blktrans.h>
+
/* these info are used in ReplUnitTable */
#define BLOCK_NIL 0xffff /* last block of a chain */
#define BLOCK_FREE 0xfffe /* free block */
--
// Bernardo Innocenti - Develer S.r.l., R&D dept.
\X/ http://www.develer.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: TRIVIAL: Fix linux/mtd/nftl.h for user-space inclusion
2004-06-01 20:15 TRIVIAL: Fix linux/mtd/nftl.h for user-space inclusion Bernardo Innocenti
@ 2004-06-01 20:29 ` David Woodhouse
2004-06-01 21:13 ` Bernardo Innocenti
0 siblings, 1 reply; 6+ messages in thread
From: David Woodhouse @ 2004-06-01 20:29 UTC (permalink / raw)
To: Bernardo Innocenti; +Cc: linux-mtd
On Tue, 2004-06-01 at 22:15 +0200, Bernardo Innocenti wrote:
> Fix linux/mtd/nftl.h for user-space inclusion (required to build mtd-utils).
>
> Please apply.
It should be including mtd/nftl-user.h not linux/nftl.h
--
dwmw2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: TRIVIAL: Fix linux/mtd/nftl.h for user-space inclusion
2004-06-01 20:29 ` David Woodhouse
@ 2004-06-01 21:13 ` Bernardo Innocenti
2004-06-01 21:25 ` David Woodhouse
0 siblings, 1 reply; 6+ messages in thread
From: Bernardo Innocenti @ 2004-06-01 21:13 UTC (permalink / raw)
To: David Woodhouse; +Cc: linux-mtd
David Woodhouse wrote:
> On Tue, 2004-06-01 at 22:15 +0200, Bernardo Innocenti wrote:
>
>>Fix linux/mtd/nftl.h for user-space inclusion (required to build mtd-utils).
>>
>>Please apply.
>
> It should be including mtd/nftl-user.h not linux/nftl.h
The header nftl-user.h doesn't exist in neither
linux-2.6.6 and in the version of mtd-utils
imported in uClinux-dist (a rather old version,
I shall admit).
If nftl.h isn't supposed to be included from user-space,
the "#ifdef __KERNEL__ ... #endif" it contains is
useless.
I may change mtd-utils locally, but I think this
fix should also go into the kernel "just in case".
--
// Bernardo Innocenti - Develer S.r.l., R&D dept.
\X/ http://www.develer.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: TRIVIAL: Fix linux/mtd/nftl.h for user-space inclusion
2004-06-01 21:13 ` Bernardo Innocenti
@ 2004-06-01 21:25 ` David Woodhouse
2004-06-01 21:39 ` Bernardo Innocenti
0 siblings, 1 reply; 6+ messages in thread
From: David Woodhouse @ 2004-06-01 21:25 UTC (permalink / raw)
To: Bernardo Innocenti; +Cc: linux-mtd
On Tue, 2004-06-01 at 23:13 +0200, Bernardo Innocenti wrote:
> David Woodhouse wrote:
> > On Tue, 2004-06-01 at 22:15 +0200, Bernardo Innocenti wrote:
> >
> >>Fix linux/mtd/nftl.h for user-space inclusion (required to build mtd-utils).
> >>
> >>Please apply.
> >
> > It should be including mtd/nftl-user.h not linux/nftl.h
>
> The header nftl-user.h doesn't exist in neither
> linux-2.6.6 and in the version of mtd-utils
> imported in uClinux-dist (a rather old version,
> I shall admit).
nftl-user.h is in CVS, along with a version of the userspace tools which
uses it.
> If nftl.h isn't supposed to be included from user-space,
> the "#ifdef __KERNEL__ ... #endif" it contains is
> useless.
It it also removed in CVS.
--
dwmw2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: TRIVIAL: Fix linux/mtd/nftl.h for user-space inclusion
2004-06-01 21:25 ` David Woodhouse
@ 2004-06-01 21:39 ` Bernardo Innocenti
2004-06-01 21:41 ` David Woodhouse
0 siblings, 1 reply; 6+ messages in thread
From: Bernardo Innocenti @ 2004-06-01 21:39 UTC (permalink / raw)
To: David Woodhouse; +Cc: linux-mtd
David Woodhouse wrote:
>>The header nftl-user.h doesn't exist in neither
>>linux-2.6.6 and in the version of mtd-utils
>>imported in uClinux-dist (a rather old version,
>>I shall admit).
>
> nftl-user.h is in CVS, along with a version of the userspace tools which
> uses it.
Ok, I'll check it out from CVS and post a patch to
the uClinux-dev mailing-list adding this header in
user/mtd-utils.
Is it 100% binary-compatible with all kernels?
--
// Bernardo Innocenti - Develer S.r.l., R&D dept.
\X/ http://www.develer.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: TRIVIAL: Fix linux/mtd/nftl.h for user-space inclusion
2004-06-01 21:39 ` Bernardo Innocenti
@ 2004-06-01 21:41 ` David Woodhouse
0 siblings, 0 replies; 6+ messages in thread
From: David Woodhouse @ 2004-06-01 21:41 UTC (permalink / raw)
To: Bernardo Innocenti; +Cc: linux-mtd
On Tue, 2004-06-01 at 23:39 +0200, Bernardo Innocenti wrote:
> David Woodhouse wrote:
>
> >>The header nftl-user.h doesn't exist in neither
> >>linux-2.6.6 and in the version of mtd-utils
> >>imported in uClinux-dist (a rather old version,
> >>I shall admit).
> >
> > nftl-user.h is in CVS, along with a version of the userspace tools which
> > uses it.
>
> Ok, I'll check it out from CVS and post a patch to
> the uClinux-dev mailing-list adding this header in
> user/mtd-utils.
>
> Is it 100% binary-compatible with all kernels?
Yes, I believe so.
--
dwmw2
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-06-01 21:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-01 20:15 TRIVIAL: Fix linux/mtd/nftl.h for user-space inclusion Bernardo Innocenti
2004-06-01 20:29 ` David Woodhouse
2004-06-01 21:13 ` Bernardo Innocenti
2004-06-01 21:25 ` David Woodhouse
2004-06-01 21:39 ` Bernardo Innocenti
2004-06-01 21:41 ` David Woodhouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox