From: David Woodhouse <dwmw2@infradead.org>
To: tglx@linutronix.de
Cc: linux-mtd@lists.infradead.org
Subject: Re: mtd/include/mtd mtd-abi.h,1.1,1.2
Date: Fri, 04 Jun 2004 09:47:54 +0100 [thread overview]
Message-ID: <1086338874.4588.62.camel@imladris.demon.co.uk> (raw)
In-Reply-To: <E1BW9s0-0007ic-LQ@phoenix.infradead.org>
On Fri, 2004-06-04 at 09:16 +0100, gleixner@infradead.org wrote:
> Log Message:
> Extend eccpos array to support HW8_512 ecc on 2k chips. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Er, you just changed the kernel<->user ABI and broke all existing
userspace tools compiled with the old one.
Which is OK since this hasn't gone to Linus yet.... but as soon as it
goes to Linus these things are set in stone and you have to extend, not
change.
Do we want a couple of ints in that structure saying how big the arrays
are? While we're at it, it's better to use explicitly sized types to
make 64<->32 bit ioctl conversion easier.
> --- mtd-abi.h 5 May 2004 14:44:57 -0000 1.1
> +++ mtd-abi.h 4 Jun 2004 08:16:06 -0000 1.2
> @@ -86,7 +86,7 @@
> struct nand_oobinfo {
> int useecc;
> int eccbytes;
> - int eccpos[24];
> + int eccpos[32];
> int oobfree[8][2];
> };
--
dwmw2
next parent reply other threads:[~2004-06-04 8:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1BW9s0-0007ic-LQ@phoenix.infradead.org>
2004-06-04 8:47 ` David Woodhouse [this message]
2004-06-04 8:47 ` mtd/include/mtd mtd-abi.h,1.1,1.2 Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1086338874.4588.62.camel@imladris.demon.co.uk \
--to=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox