public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Ian Campbell <icampbell@arcom.com>
To: Linux MTD Mailing List <linux-mtd@lists.infradead.org>
Subject: Re: chip driver mar_ram.c never sets MTD_ERASE_DONE state
Date: Thu, 17 Jun 2004 15:43:24 +0100	[thread overview]
Message-ID: <1087483404.27907.8.camel@icampbell-debian> (raw)
In-Reply-To: <40D1A1F2.1000103@sysgo.com>

On Thu, 2004-06-17 at 14:51, Oliver Kühlert wrote:
> trying to erase on an mtd devices using the map_ram.c driver
> blocks the current process and never wakes up. (see mtdchar.c, ioctl func)
> 
> I believe, that this can be fixed by adding the marked line in map_ram.c:

I believe that to be correct -- I posted a patch here quite some time
ago
http://lists.infradead.org/pipermail/linux-mtd/2002-November/006436.html

Please could someone who has CVS access commit it? Perhaps I should also
submit to the kernel list?

Ian.

%patch
Index: q/drivers/mtd/chips/map_ram.c
===================================================================
--- q.orig/drivers/mtd/chips/map_ram.c	Tue Aug  5 16:46:21 2003
+++ q/drivers/mtd/chips/map_ram.c	Tue Aug  5 16:46:37 2003
@@ -109,6 +109,8 @@
 	for (i=0; i<instr->len; i++)
 		map_write8(map, 0xFF, instr->addr + i);
 
+	instr->state = MTD_ERASE_DONE;
+
 	if (instr->callback)
 		instr->callback(instr);
 

%diffstat
 map_ram.c |    2 ++
 1 files changed, 2 insertions(+)


-- 
Ian Campbell, Senior Design Engineer
                                        Web: http://www.arcom.com
Arcom, Clifton Road, 			Direct: +44 (0)1223 403 465
Cambridge CB1 7EA, United Kingdom	Phone:  +44 (0)1223 411 200

      parent reply	other threads:[~2004-06-17 14:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-17 13:51 chip driver mar_ram.c never sets MTD_ERASE_DONE state Oliver Kühlert
2004-06-17 14:08 ` Thomas Gleixner
2004-06-17 14:43 ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1087483404.27907.8.camel@icampbell-debian \
    --to=icampbell@arcom.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox