From: "Øyvind Harboe" <oyvind.harboe@zylin.com>
To: linux-mtd@lists.infradead.org
Subject: Prune obsolete raw_node_ref's from RAM
Date: Tue, 13 Jul 2004 16:18:16 +0200 [thread overview]
Message-ID: <1089728296.6288.19.camel@famine> (raw)
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
This patch prunes raw_node_ref's from RAM so as to achieve a fixed
steady state RAM memory footprint when the number of files is constant.
The diff is against the eCos repository since thats where all this
started:
http://ecos.sourceware.org/ml/ecos-discuss/2004-07/msg00158.html
Remaining issues to be checked:
- Is the code correct?
- What performance impact does it have?
--
Øyvind Harboe
http://www.zylin.com
[-- Attachment #2: memleakfix.txt --]
[-- Type: text/x-patch, Size: 2040 bytes --]
Index: nodemgmt.c
===================================================================
RCS file: /cvs/ecos/ecos/packages/fs/jffs2/current/src/nodemgmt.c,v
retrieving revision 1.6
diff -w -u -r1.6 nodemgmt.c
--- nodemgmt.c 11 Dec 2003 23:33:54 -0000 1.6
+++ nodemgmt.c 13 Jul 2004 13:35:44 -0000
@@ -549,6 +549,60 @@
printk(KERN_WARNING "Short write in obliterating obsoleted node at 0x%08x: %zd\n", ref_offset(ref), retlen);
return;
}
+
+ // Merge obsolete nodes into its previous node, i.e. always leave
+ // one node behind so as not to screw up ref_totlen()
+ if (ref->next_in_ino!=NULL)
+ {
+ bool moreToDo;
+ do {
+ moreToDo=false;
+ struct jffs2_inode_cache *ic;
+ ic = jffs2_raw_ref_to_ic(ref);
+
+ // unlink the node and
+ struct jffs2_raw_node_ref *raw;
+ struct jffs2_raw_node_ref *prev=NULL;
+ raw = ic->nodes;
+ for (raw = ic->nodes; raw != (void *)ic; raw = raw->next_in_ino) {
+ // if this node *and* the previous *physical node* are obsolete, combine them.
+ if ((prev!=NULL)&&ref_obsolete(raw)) {
+ // now take take it off the physcial list, unless it is the
+ // first node.
+ struct jffs2_raw_node_ref *t;
+ struct jffs2_raw_node_ref *phys_prev=NULL;
+ t=jeb->first_node;
+ while (t!=NULL) {
+ if ((phys_prev!=NULL)&&(t==raw)&&ref_obsolete(prev)) {
+ // take it off the inode list.
+ prev->next_in_ino=t->next_in_ino;
+
+ // take it off the physical list
+ phys_prev->next_phys=t->next_phys;
+ // update last physical entry pointer...
+ if (jeb->last_node==t) {
+ jeb->last_node=t->next_phys;
+ }
+
+ // update physical __totlen field.
+ phys_prev->__totlen+=t->__totlen;
+
+
+ jffs2_free_raw_node_ref(raw);
+ moreToDo=true;
+
+ break;
+ }
+ phys_prev=t;
+ t=t->next_phys;
+ }
+ break;
+ }
+ prev=raw;
+ }
+ } while (moreToDo);
+ }
+
}
#if CONFIG_JFFS2_FS_DEBUG > 0
next reply other threads:[~2004-07-13 14:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-13 14:18 Øyvind Harboe [this message]
2004-07-13 23:14 ` Prune obsolete raw_node_ref's from RAM David Woodhouse
2004-07-14 6:26 ` Øyvind Harboe
2004-07-14 6:41 ` David Woodhouse
2004-07-14 6:51 ` Øyvind Harboe
2004-07-14 7:08 ` David Woodhouse
2004-07-14 7:27 ` Øyvind Harboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1089728296.6288.19.camel@famine \
--to=oyvind.harboe@zylin.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox