public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: "Øyvind Harboe" <oyvind.harboe@zylin.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: Prune obsolete raw_node_ref's from RAM
Date: Wed, 14 Jul 2004 08:26:48 +0200	[thread overview]
Message-ID: <1089786408.7607.4.camel@famine> (raw)
In-Reply-To: <1089760454.8822.23.camel@imladris.demon.co.uk>

On Wed, 2004-07-14 at 01:14, David Woodhouse wrote:
> On Tue, 2004-07-13 at 16:18 +0200, Øyvind Harboe wrote:
> > - Is the code correct? 
> 
> It looks OK at first glance but I can't actually tell. List mangling
> code is hard enough to read when it's in the style I understand :)
> 
> I've rewritten it and just posted that version. 

Excellent! I'll make sure to run my tests with your new version.

> > - What performance impact does it have? 
> 
> It'll go walking the lists every time a node is obsoleted. My guess is
> it'll make the performance suck _hard_. But it will get you your memory
> back. I suspect it should be a configuration option -- or maybe we could
> stick the list-walking code into a separate function and call it
> periodically to do the cleanup, rather than doing it every time.

Note that in my case I have the following usage:

- Little RAM(so freeing up is essential)
- Big flash disk(mainly for wear levelling purposes).
- Few and small files
- Lots of deleted nodes
- The application overwrites existing files with regular intervals

In this scenario, the performance should be fine.

In a scneario with:

- lots of files
- lots of ram
- occasional freing up

Performance should suck.

> Could do with seeing some profiling info.

Would all the performance problems go away if the lists were doubly
linked?

-- 
Øyvind Harboe
http://www.zylin.com

  reply	other threads:[~2004-07-14  6:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-13 14:18 Prune obsolete raw_node_ref's from RAM Øyvind Harboe
2004-07-13 23:14 ` David Woodhouse
2004-07-14  6:26   ` Øyvind Harboe [this message]
2004-07-14  6:41     ` David Woodhouse
2004-07-14  6:51       ` Øyvind Harboe
2004-07-14  7:08         ` David Woodhouse
2004-07-14  7:27           ` Øyvind Harboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1089786408.7607.4.camel@famine \
    --to=oyvind.harboe@zylin.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox