From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [2002:d592:9a28::1] (helo=pentafluge.infradead.org) by canuck.infradead.org with esmtp (Exim 4.33 #1 (Red Hat Linux)) id 1BmjAP-0006TX-Rc for linux-mtd@lists.infradead.org; Mon, 19 Jul 2004 21:11:38 -0400 From: David Woodhouse To: =?ISO-8859-1?Q?=D8yvind?= Harboe In-Reply-To: <1090250145.14173.3.camel@famine> References: <1089643331.3951.42.camel@famine> <1089711000.2899.96.camel@hades.cambridge.redhat.com> <1089712151.5995.21.camel@famine> <1089713133.2899.117.camel@hades.cambridge.redhat.com> <1089726079.6288.5.camel@famine> <1089759689.8822.18.camel@imladris.demon.co.uk> <1089792912.7607.22.camel@famine> <1090246707.13401.18.camel@famine> <1090250145.14173.3.camel@famine> Content-Type: text/plain; charset=UTF-8 Date: Mon, 19 Jul 2004 21:10:39 -0400 Message-Id: <1090285839.4149.8.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: linux-mtd@lists.infradead.org, ecos-discuss@sources.redhat.com Subject: Re: JFFS2 eats memory List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2004-07-19 at 17:15 +0200, Øyvind Harboe wrote: > At this point I'm just trying to find a fix that is correct. Well yes, but this _is_ a performance optimisation you're doing :) > > Can't you adjust gc_node instead? > > I don't know. > > What should I adjust it to? gc_node is the next node to be garbage-collected. We don't need to garbage-collect nodes which are already obsolete. So if you're freeing the object which is currently pointed to by jeb->gc_node, you can just make gc_node point to the next_phys node which you're _not_ freeing. -- dwmw2