public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: "Øyvind Harboe" <oyvind.harboe@zylin.com>
Cc: linux-mtd@lists.infradead.org, ecos-discuss@sources.redhat.com
Subject: Re: JFFS2 eats memory
Date: Wed, 21 Jul 2004 07:51:43 -0400	[thread overview]
Message-ID: <1090410703.4280.10.camel@localhost.localdomain> (raw)
In-Reply-To: <1090391133.15766.4.camel@famine>

On Wed, 2004-07-21 at 08:25 +0200, Øyvind Harboe wrote:

> in gc.c:

> -	241		if (!raw->next_in_ino) {

> -	251		ic = jffs2_raw_ref_to_ic(raw);

Hmmm. Surely you shouldn't be able to get to those in the case where
gc_node is NULL? You should hit the condition at line 218 because
jeb->user_size should be zero.

Remember, gc_node is the placemarker for the garbage-collector which is
busily obsoleting every node in this block so that the block can be
erased and returned to the free pool. If you were freeing a node, and
there was no 'next' node when you did so, that must have meant you got
to the end of the eraseblock, surely?

Obviously I'm wrong -- you have empirical evidence. But why?

PS. Will somebody please kick Beat Morf <beat.morf@duagon.ch> off the
eCos list? He has an extremely broken autoresponder -- it's replying to
the From: address in the mail instead of the SMTP reverse-path, it's
replying with non-error message status so that it can cause mail loops,
and it's not even rate-limited. I get a response for every mail I send.

-- 
dwmw2

  reply	other threads:[~2004-07-21 11:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1089643331.3951.42.camel@famine>
     [not found] ` <1089711000.2899.96.camel@hades.cambridge.redhat.com>
     [not found]   ` <1089712151.5995.21.camel@famine>
     [not found]     ` <1089713133.2899.117.camel@hades.cambridge.redhat.com>
     [not found]       ` <1089726079.6288.5.camel@famine>
2004-07-13 23:01         ` JFFS2 eats memory David Woodhouse
2004-07-14  8:15           ` Øyvind Harboe
2004-07-19 14:18             ` Øyvind Harboe
2004-07-19 14:24               ` David Woodhouse
2004-07-19 15:15                 ` Øyvind Harboe
2004-07-20  1:10                   ` David Woodhouse
2004-07-20  6:41                     ` Øyvind Harboe
2004-07-20 13:45                       ` David Woodhouse
2004-07-20 15:28                         ` Øyvind Harboe
2004-07-20 15:54                           ` David Woodhouse
2004-07-20 18:52                             ` Øyvind Harboe
2004-07-20 22:08                               ` David Woodhouse
2004-07-21  6:25                                 ` Øyvind Harboe
2004-07-21 11:51                                   ` David Woodhouse [this message]
2004-07-21 12:03                                     ` Øyvind Harboe
2004-07-21 13:25                                       ` David Woodhouse
2004-07-20 13:37                     ` Øyvind Harboe
2008-04-08 15:16 Jürgen Lambrecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1090410703.4280.10.camel@localhost.localdomain \
    --to=dwmw2@infradead.org \
    --cc=ecos-discuss@sources.redhat.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=oyvind.harboe@zylin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox