From: Thomas Gleixner <tglx@linutronix.de>
To: Brad Beveridge <bbeveridge@bluewatersys.com>
Cc: MTD mailing list <linux-mtd@lists.infradead.org>
Subject: Re: BUG in nand_base.c
Date: Wed, 06 Oct 2004 10:28:28 +0200 [thread overview]
Message-ID: <1097051308.3045.4.camel@lap02.tec.linutronix.de> (raw)
In-Reply-To: <41636AD5.4020403@bluewatersys.com>
On Wed, 2004-10-06 at 05:47, Brad Beveridge wrote:
> Hi all, I have been playing with large size nand devices & have found
> what I think is a bug in nand_base.c::nand_command. I have the latest
> daily snapshot.
> Starting at line 546, there is the following code
> /* One more address cycle for higher density
> devices */
> if (this->chipsize & 0x0c000000)
> this->write_byte(mtd, (unsigned char)
> ((page_addr >> 16) & 0x0f));
> Which will correctly trap the 4th write cycle for 64 & 128MiB parts, but
> not for larger sizes of 256 & 512 MiB.
> In my code I have changed the line to read
> if (this->chipsize & 0xfc000000)
>
> Also, I noticed that for the large page devices (nand_command_lp) a
> proper compare (>) is used instead of a mask - should one of these be
> changed to make both functions consistant?
You're right. I will fix this later when I have CVS access again.
Thanks
tglx
prev parent reply other threads:[~2004-10-06 8:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-06 3:47 BUG in nand_base.c Brad Beveridge
2004-10-06 8:28 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1097051308.3045.4.camel@lap02.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=bbeveridge@bluewatersys.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox