From: Thomas Gleixner <tglx@linutronix.de>
To: simon@baydel.com
Cc: linux-mtd@lists.infradead.org
Subject: Re: Bad Blocks On JFFS2/NAND
Date: Tue, 19 Oct 2004 17:02:28 +0200 [thread overview]
Message-ID: <1098198148.12223.885.camel@thomas> (raw)
In-Reply-To: <E0CCB8742B31@baydel.com>
On Tue, 2004-10-19 at 16:39, Simon Haynes wrote:
> Thomas,
>
> I am using the ready pin.
Hmm, the strange thing is, that it does not complain about a failed
erase. It complaines, when checking if the chip is really erased.
Can you try the hack below, which invalidates the page cache
unconditionally on erase ?
tglx
RCS file: /home/cvs/mtd/drivers/mtd/nand/nand_base.c,v
retrieving revision 1.121
diff -u -r1.121 nand_base.c
--- nand_base.c 6 Oct 2004 19:53:11 -0000 1.121
+++ nand_base.c 19 Oct 2004 15:09:35 -0000
@@ -2091,8 +2091,7 @@
/* Invalidate the page cache, if we erase the block
which contains
the current cached page */
- if (page <= this->pagebuf && this->pagebuf < (page +
pages_per_block))
- this->pagebuf = -1;
+ this->pagebuf = -1;
this->erase_cmd (mtd, page & this->pagemask);
next prev parent reply other threads:[~2004-10-19 15:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-19 11:22 Bad Blocks On JFFS2/NAND Simon Haynes
2004-10-19 11:50 ` Thomas Gleixner
2004-10-19 14:39 ` Simon Haynes
2004-10-19 15:02 ` Thomas Gleixner [this message]
2004-10-19 15:18 ` Simon Haynes
2004-10-19 21:45 ` Michael Moedt
2004-10-19 21:55 ` Thomas Gleixner
2004-10-20 9:40 ` Simon Haynes
2004-10-20 9:53 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098198148.12223.885.camel@thomas \
--to=tglx@linutronix.de \
--cc=linux-mtd@lists.infradead.org \
--cc=simon@baydel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox