Re: JFFS2 prints

David Woodhouse
2004-11-13T11:38:19Z

On Sat, 2004-11-13 at 14:26 +0300, Artem B. Bityuckiy wrote:
> But the main thing why I think it would be nice to introduce macros like
> these is that the messages will be a bit standard. I mean that all
> errors will have the same prefix. It is useful when you develop JFFS2
> with debugging output on. In this case you will just s/JFFS2 Error and
> see all the error messages. But currently, it is hard to find all the
> error messages in JFFS2 because some of them use prefix "Error", some
> just contain the word "failed", etc.

I'm not sure that just a standard prefix will really help with
debugging. The trick is still to know what's important, and what's
noise. And running it with full debugging is slow enough already over a
115200 baud serial line, without adding more stuff to each line :)

I'd much rather see an effort to weed out the unnecessary prints at
debug level 1, moving them to level 2. I don't consider level 2 to be
particularly useful in general; it's _too_ verbose.

--
dwmw2