From: David Woodhouse <dwmw2@redhat.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] MTD: some cleanups
Date: Tue, 16 Nov 2004 18:26:07 +0000 [thread overview]
Message-ID: <1100629567.8191.6993.camel@hades.cambridge.redhat.com> (raw)
In-Reply-To: <20041112135322.GB7707@stusta.de>
On Fri, 2004-11-12 at 14:53 +0100, Adrian Bunk wrote:
> The patch below makes the following cleanups for code under drivers/mtd/ :
> - make some needlessly global code static
OK.
> - remove the following unused code:
> - function ftl_freepart in drivers/mtd/ftl.c
It's a bug that we never free these. We should call the function
occasionally instead of deleting it.
> - functions nettel_eraseconfig and nettel_erasecallback,
> struct nettel_erase in drivers/mtd/maps/nettel.c
The nettel_eraseconfig() function isn't static -- I assume it was called
from the nettel-specific platform code.
> - function physmap_set_partitions in drivers/mtd/maps/physmap.c
Again that's called from elsewhere.
--
dwmw2
next prev parent reply other threads:[~2004-11-16 18:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-12 13:53 [2.6 patch] MTD: some cleanups Adrian Bunk
2004-11-16 18:26 ` David Woodhouse [this message]
2004-11-21 18:01 ` Adrian Bunk
2004-11-21 18:06 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1100629567.8191.6993.camel@hades.cambridge.redhat.com \
--to=dwmw2@redhat.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox