public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Konstantin Kletschke <lists@ku-gbr.de>
Cc: linux-mtd@lists.infradead.org
Subject: Re: jffs2 Oops on 2.6.10-rc2
Date: Sat, 20 Nov 2004 16:34:27 +0000	[thread overview]
Message-ID: <1100968467.7949.8.camel@localhost.localdomain> (raw)
In-Reply-To: <20041120163510.GD7984@ku-gbr.de>

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

On Sat, 2004-11-20 at 17:35 +0100, Konstantin Kletschke wrote:
> Sadly I overlooked your other (cvs comitted) patch this evening and I am
> at home now, what a pity... That would have cleared the situation up in
> 5 minutes :/

No it wouldn't -- that isn't the problem either. I _think_ this is...

-- 
dwmw2

[-- Attachment #2: Attached message - mtd/fs/jffs2 build.c,1.64,1.65 --]
[-- Type: message/rfc822, Size: 3393 bytes --]

From: David Woodhouse <dwmw2@infradead.org>
To: linux-mtd-cvs@lists.infradead.org
Subject: mtd/fs/jffs2 build.c,1.64,1.65
Date: Sat, 20 Nov 2004 16:19:42 +0000
Message-ID: <E1CVXxd-00050i-W8@phoenix.infradead.org>

Update of /home/cvs/mtd/fs/jffs2
In directory phoenix.infradead.org:/tmp/cvs-serv19258

Modified Files:
	build.c 
Log Message:
Fix freeing of refs belonging to unlinked inode


Index: build.c
===================================================================
RCS file: /home/cvs/mtd/fs/jffs2/build.c,v
retrieving revision 1.64
retrieving revision 1.65
diff -u -r1.64 -r1.65
--- build.c	20 Nov 2004 10:44:07 -0000	1.64
+++ build.c	20 Nov 2004 16:19:38 -0000	1.65
@@ -191,9 +191,12 @@
 
 	D1(printk(KERN_DEBUG "JFFS2: Removing ino #%u with nlink == zero.\n", ic->ino));
 	
-	for (raw = ic->nodes; raw != (void *)ic; raw = raw->next_in_ino) {
+	raw = ic->nodes;
+	while (raw != (void *)ic) {
+		struct jffs2_raw_node_ref *next = raw->next_in_ino;
 		D1(printk(KERN_DEBUG "obsoleting node at 0x%08x\n", ref_offset(raw)));
 		jffs2_mark_node_obsolete(c, raw);
+		raw = next;
 	}
 
 	if (ic->scan_dents) {


__________________________________________________________
Linux-MTD CVS commit list
http://lists.infradead.org/mailman/listinfo/linux-mtd-cvs/

  reply	other threads:[~2004-11-20 16:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-18 16:35 jffs2 Oops on 2.6.10-rc2 Konstantin Kletschke
2004-11-18 17:20 ` Konstantin Kletschke
2004-11-20 13:57 ` David Woodhouse
2004-11-20 14:47   ` David Woodhouse
2004-11-20 14:50   ` Konstantin Kletschke
2004-11-20 14:57     ` David Woodhouse
2004-11-20 15:13       ` Artem B. Bityuckiy
2004-11-20 16:28         ` Konstantin Kletschke
2004-11-20 16:31       ` Konstantin Kletschke
2004-11-20 16:35       ` Konstantin Kletschke
2004-11-20 16:34         ` David Woodhouse [this message]
2004-11-22 10:27           ` Ian Campbell
2004-11-22 10:50             ` Ian Campbell
2004-11-22 11:05               ` David Woodhouse
2004-11-22 11:42                 ` Ian Campbell
2004-11-20 15:12     ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1100968467.7949.8.camel@localhost.localdomain \
    --to=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=lists@ku-gbr.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox