From: David Woodhouse <dwmw2@infradead.org>
To: Estelle HAMMACHE <estelle.hammache@st.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: JFFS2 & NAND failure
Date: Sat, 20 Nov 2004 19:19:26 +0000 [thread overview]
Message-ID: <1100978366.7949.38.camel@localhost.localdomain> (raw)
In-Reply-To: <419E1DE0.FDD5DEC0@st.com>
On Fri, 2004-11-19 at 17:22 +0100, Estelle HAMMACHE wrote:
>
> Here is an example of the obsolete node/refiled nextblock pb:
> - page size 512 bytes
> - start condition: wbuf contains 500 bytes
> jffs2_write_dnode call, total node size 700 bytes
> -->jffs2_flash_writev
> ------>fill up wbuf
> ------>donelen = 12
> ------>jffs2_flush_wbuf (succeeds)
> ------>c->mtd->writev_ecc to write 1 page - fails
> ------>nextblock is refiled (new code!)
> ------>*retlen = donelen (= 12)
> -->add obsolete frag for dirtied space
> ------> free raw node & return early because c->nextblock == 0
> -->probable segfault on (redundant?) jffs2_mark_node_obsolete
> -->retry.
This is the problem, surely? If we've refiled the nextblock, we should
return retlen == 0.
--
dwmw2
next prev parent reply other threads:[~2004-11-20 19:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-17 17:15 JFFS2 & NAND failure Estelle HAMMACHE
2004-11-18 16:27 ` David Woodhouse
2004-11-18 17:54 ` Estelle HAMMACHE
2004-11-19 13:17 ` David Woodhouse
2004-11-19 16:22 ` Estelle HAMMACHE
2004-11-20 18:57 ` David Woodhouse
2004-11-20 19:19 ` David Woodhouse [this message]
2004-11-20 22:13 ` David Woodhouse
2004-12-09 14:57 ` David Woodhouse
2004-12-09 17:06 ` Estelle HAMMACHE
2004-12-15 12:33 ` Estelle HAMMACHE
2005-02-02 16:21 ` Estelle HAMMACHE
2005-04-04 12:58 ` Artem B. Bityuckiy
2005-04-04 13:58 ` Estelle HAMMACHE
2005-04-04 14:47 ` Artem B. Bityuckiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1100978366.7949.38.camel@localhost.localdomain \
--to=dwmw2@infradead.org \
--cc=estelle.hammache@st.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox