Re: PATCH to help understanding

[Thomas Gleixner <tglx@linutronix.de>]

On Fri, 2004-12-17 at 16:24 +1300, Charles Manning wrote:
> Hi folks
> 
> I propose the following patches to mtd.h to help the understanding of these 
> functions.
> 
> read_ecc() and write_ecc() use the argument eccbuff, but this is really oob 
> data being passed. The oob data might contain ecc info as well as other 
> stuff. With the preferred autoplacement model, this will not have ecc info in 
> it. Therefore I suggest a rename on this parameter.

Makes sense.

> suspend() and resume() are surely the functions for erase suspend and erase 
> resume (for those NOR devices that provide this). Perhaps I goofed here and 
> these are really power control functions (which would seem rather dodgy). If 
> these are really power control fns, then where does erase suspend/resume get 
> exposed?

Those are PM functions. The sole purpose of suspend is to disable the
access to the chip until resume is called, so you can power down safely.
I will add those to the NAND driver for completeness.

Erase suspend/resume is nowhere exposed. It is handled inside the chip
family drivers. For NAND we removed the erase suspend because it does
not work on all chips and the erase time is short anyway so it's not
worth the extra trouble.

tglx