public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Frantisek Rysanek <Frantisek.Rysanek@post.cz>
Cc: linux-mtd@lists.infradead.org
Subject: Re: several bugfixes/workarounds in mtd snapshot of 20041226 && 2.4.28
Date: Wed, 05 Jan 2005 17:36:12 +0000	[thread overview]
Message-ID: <1104946572.13016.323.camel@hades.cambridge.redhat.com> (raw)
In-Reply-To: <41D2C8E3.26470.C13D47B@localhost>

On Wed, 2004-12-29 at 15:10 +0100, Frantisek Rysanek wrote:
> 1) if you flush the partition table and issue a BLKRRPART 
> (i.e., you re-partition the diskonchip), the reported device 
> size shrinks to one half of the original. If you do this again 
> before a reboot, the size shrinks again (now one quarter).
> Seems like the driver would re-init device size to a size denominated in 1k blocks,
> rather than sectors (512B).

Committed. Thanks.

> 2) in my DiskOnChip-only setup, CONFIG_MTD_MAP_BANK_WIDTH_1 
> is missing in the .config. I've added that straight to $LINUX/include/linux/map.h

I think that's a Config.in bug -- it shouldn't happen on 2.6.

> 3) two #includes seem to be missing in $MTD/nand/diskonchip.c

rslib.h was already there; I've added moduleparam.h which was not.

> 4) the Reed-Solomon library hooks are messed up in $LINUX/lib/Config.in

Committed; thanks.

-- 
dwmw2

      reply	other threads:[~2005-01-05 17:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-29 14:10 several bugfixes/workarounds in mtd snapshot of 20041226 && 2.4.28 Frantisek Rysanek
2005-01-05 17:36 ` David Woodhouse [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1104946572.13016.323.camel@hades.cambridge.redhat.com \
    --to=dwmw2@infradead.org \
    --cc=Frantisek.Rysanek@post.cz \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox