public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "David A. Marlin" <dmarlin@redhat.com>
Cc: MTD List <linux-mtd@lists.infradead.org>
Subject: Re: additional error checks for AG-AND erase/write
Date: Fri, 21 Jan 2005 10:27:38 +0100	[thread overview]
Message-ID: <1106299658.5483.16.camel@tglx.tec.linutronix.de> (raw)
In-Reply-To: <41F03217.3070300@redhat.com>

On Thu, 2005-01-20 at 16:35 -0600, David A. Marlin wrote:
> Attached is a patch that I think implements what you described.  Please 
> let me know if I've missed anything or gone astray in the details.

Looks good.

> Note:  I changed a few literals to defined symbols in 'nand_base.c'. 
> Please let me know if you would prefer this in a separate patch (or not 
> at all).

If it's not too much work it would be nice when you can do this change
first.

> @@ -1052,6 +1062,30 @@
>  static int nand_read_ecc (struct mtd_info *mtd, loff_t from, size_t len,
>  			  size_t * retlen, u_char * buf, u_char * oob_buf, struct nand_oobinfo *oobsel)
>  {
> +	return do_nand_read_ecc(mtd, from, len, retlen, buf, oob_buf, oobsel, 0xff);
> +}

Can you please change the call in nand_read too, so it calls
do_nand_read_ecc directly instead of doing the double call ?

tglx

  reply	other threads:[~2005-01-21  9:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-18 15:43 additional error checks for AG-AND erase/write David A. Marlin
2005-01-18 17:19 ` Thomas Gleixner
2005-01-18 18:08   ` David A. Marlin
2005-01-18 21:15     ` Thomas Gleixner
2005-01-20 22:35       ` David A. Marlin
2005-01-21  9:27         ` Thomas Gleixner [this message]
2005-01-21 15:04           ` David A. Marlin
2005-01-22  9:05             ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1106299658.5483.16.camel@tglx.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=dmarlin@redhat.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox