From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Woodhouse To: Christoph Hellwig In-Reply-To: <20050418124656.GA23387@infradead.org> References: <1113814031.31595.3.camel@sauron.oktetlabs.ru> <20050418085121.GA19091@infradead.org> <1113814730.31595.6.camel@sauron.oktetlabs.ru> <20050418105301.GA21878@infradead.org> <1113824781.2125.12.camel@sauron.oktetlabs.ru> <20050418115220.GA22750@infradead.org> <1113827466.2125.47.camel@sauron.oktetlabs.ru> <20050418124656.GA23387@infradead.org> Content-Type: text/plain Date: Mon, 18 Apr 2005 23:08:26 +1000 Message-Id: <1113829708.5286.30.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATC] small VFS change for JFFS2 List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2005-04-18 at 13:46 +0100, Christoph Hellwig wrote: > Any, this sounds like you'd want to use ilookup because you don't want > to read the inode in the cache anyway, right? We use ilookup() in some circumstances -- if the inode has zero nlink and hence we definitely don't want to pull it back again if it's gone. But sometimes we really do mean to use iget() to bring it into core. And it's in that case that I believe Artem has found the problem, because if I understand correctly he's still seeing two consecutive calls to read_inode() for the same inode, without a clear_inode() in between. prune_icache() is removing the inode from i_hash at line 457 of inode.c, then being preempted when it drops the inode_lock at line 464, which is _before_ it calls dispose_list() to actually get rid of the inode(s) in question. So when iget() is called, the VFS ends up calling read_inode() again instead of waiting for the original inode to finish going away. -- dwmw2