From: David Woodhouse <dwmw2@infradead.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATC] small VFS change for JFFS2
Date: Mon, 18 Apr 2005 23:16:51 +1000 [thread overview]
Message-ID: <1113830212.5286.33.camel@localhost.localdomain> (raw)
In-Reply-To: <20050418124656.GA23387@infradead.org>
On Mon, 2005-04-18 at 13:46 +0100, Christoph Hellwig wrote:
> Why doesn't __wait_on_freeing_inode get called? prune_icache sets
> I_FREEING before it's dropping the inode lock.
Because prune_icache() _also_ removes the inode from the hash before
dropping the inode lock. It shouldn't -- the inode should only get
removed from the hash when it's actually been cleared. That's the real
bug -- and I agree that the fix isn't to expose internal locks to let
JFFS2 work around it.
prune_icache() (and probably invalidate_inodes() too) needs to leave the
inode on the hash list while it's being freed.
--
dwmw2
next prev parent reply other threads:[~2005-04-18 13:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-18 8:47 [PATC] small VFS change for JFFS2 Artem B. Bityuckiy
2005-04-18 8:51 ` Christoph Hellwig
2005-04-18 8:58 ` Artem B. Bityuckiy
2005-04-18 10:53 ` Christoph Hellwig
2005-04-18 11:46 ` Artem B. Bityuckiy
2005-04-18 11:52 ` Christoph Hellwig
2005-04-18 12:31 ` Artem B. Bityuckiy
2005-04-18 12:46 ` David Woodhouse
2005-04-18 12:46 ` Christoph Hellwig
2005-04-18 12:56 ` Artem B. Bityuckiy
2005-04-18 13:08 ` David Woodhouse
2005-04-18 13:38 ` ntfs ->iput use - was: " Anton Altaparmakov
2005-04-18 13:16 ` David Woodhouse [this message]
2005-04-18 14:07 ` Artem B. Bityuckiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1113830212.5286.33.camel@localhost.localdomain \
--to=dwmw2@infradead.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox