From: Thomas Gleixner <tglx@linutronix.de>
To: "Artem B. Bityuckiy" <dedekind@infradead.org>
Cc: MTD <linux-mtd@lists.infradead.org>
Subject: [JFFS2] Cleanup the debugging stuff
Date: Sun, 17 Jul 2005 12:10:14 +0200 [thread overview]
Message-ID: <1121595014.24449.220.camel@tglx.tec.linutronix.de> (raw)
> Move most of debugging-related JFFS2 stuff to debug.c and debug.h. It is much
> tidier then the previous approach. Preserve dwmw2's favourite D1() - I would
> like to clean-up them as well, but do not dare. :-)
>
Why not ? I prefer a coherent cleanup over some halfarsed attempt.
> D1(printk(KERN_DEBUG "Scanned flash completely\n"));
Whats wrong with
jffs2_dbg1_msg("Scanned flash completely\n"); ?
All those D1 messages should have KERN_DEBUG syslog level, so its simple
to wrap them nicely.
> - D2(jffs2_dump_block_lists(c));
> + D2(jffs2_dbg_dump_block_lists(c));
Why D2() here ? jffs2_dbg2_dump_block_lists(c) removes D2() and provides
a quick association to the debug level.
tglx
next reply other threads:[~2005-07-17 10:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-17 10:10 Thomas Gleixner [this message]
2005-07-17 10:30 ` [JFFS2] Cleanup the debugging stuff Artem B. Bityuckiy
2005-07-17 10:47 ` Thomas Gleixner
2005-07-17 10:51 ` Artem B. Bityuckiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1121595014.24449.220.camel@tglx.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=dedekind@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox