From: "Øyvind Harboe" <oyvind.harboe@zylin.com>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: linux-mtd@lists.infradead.org
Subject: Re: PATCH: allow JFFS2 to write to really small disks
Date: Thu, 01 Sep 2005 13:12:56 +0200 [thread overview]
Message-ID: <1125573176.30825.17.camel@localhost.localdomain> (raw)
In-Reply-To: <20050901100535.GA30932@wohnheim.fh-wedel.de>
> > /* When do we let the GC thread run in the background */
> >
> > c->resv_blocks_gctrigger = c->resv_blocks_write + 1;
>
> Minor stuff: You indentation is broken.
Will fix of course. What emacs mode should I use for indentation? :-)
> If you changed the patch to add a mount option for the WORM case and
> check for the mount option instead, this might go in. Looks like it
> could be useful.
I prefer it the way it is now. There are less options to read up on and
document.
W.r.t. documentation it would possibly call for a footnote that the
JFFS2 disk will only support read/write many times if it is large
enough. If it is too small, it only supports Write Once Read Many.
What do you think?
--
Øyvind Harboe
http://www.zylin.com
next prev parent reply other threads:[~2005-09-01 11:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-31 9:28 PATCH: allow JFFS2 to write to really small disks Øyvind Harboe
2005-09-01 10:05 ` Jörn Engel
2005-09-01 11:12 ` Øyvind Harboe [this message]
2005-09-01 11:44 ` Jörn Engel
2005-09-01 11:52 ` Øyvind Harboe
2005-09-01 12:00 ` Jörn Engel
2005-09-01 12:45 ` Øyvind Harboe
2005-09-01 12:57 ` Jörn Engel
2005-09-01 13:00 ` Josh Boyer
2005-09-01 13:06 ` Øyvind Harboe
2005-09-02 12:44 ` Øyvind Harboe
2005-09-04 9:00 ` Jörn Engel
2005-09-05 10:05 ` oyvind.harboe
2005-09-05 10:27 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1125573176.30825.17.camel@localhost.localdomain \
--to=oyvind.harboe@zylin.com \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox