Re: mtd/drivers/mtd/nand sharpsl.c,1.4,1.5

Re: mtd/drivers/mtd/nand sharpsl.c,1.4,1.5

[Jörn Engel]

On Tue, 6 September 2005 15:46:18 +0100, rpurdie@infradead.org wrote:
> 
> -	if (machine_is_husky()) {
> +	if (machine_is_husky() || machine_is_borzoi()) {
>  		/* Need to use small eraseblock size for backward compatibility */
>  		sharpsl_mtd->flags |= MTD_NO_VIRTBLOCKS;
>  	}

With Ferenc's patch in, MTD_NO_VIRTBLOCKS has lost its effect.  I
guess we will remove that flag sometime in the near future.

Jörn

-- 
Why do musicians compose symphonies and poets write poems?
They do it because life wouldn't have any meaning for them if they didn't.
That's why I draw cartoons.  It's my life.
-- Charles Shultz

Re: mtd/drivers/mtd/nand sharpsl.c,1.4,1.5

[Richard Purdie]

On Tue, 2005-09-06 at 17:08 +0200, Jörn Engel wrote:
> On Tue, 6 September 2005 15:46:18 +0100, rpurdie@infradead.org wrote:
> > 
> > -	if (machine_is_husky()) {
> > +	if (machine_is_husky() || machine_is_borzoi()) {
> >  		/* Need to use small eraseblock size for backward compatibility */
> >  		sharpsl_mtd->flags |= MTD_NO_VIRTBLOCKS;
> >  	}
> 
> With Ferenc's patch in, MTD_NO_VIRTBLOCKS has lost its effect.  I
> guess we will remove that flag sometime in the near future.

I'm running mainline mtd so I guess I haven't seen this yet.

The problem is that on the Sharp Zaurus series we're stuck with a ROM
bootloader that flashes the partitions in a certain way. The above flag
allowed us to stay compatible with that and is quite important. I'm not
sure where this leaves us...

Thanks for the heads up though.

Richard

Re: mtd/drivers/mtd/nand sharpsl.c,1.4,1.5

[Jörn Engel]

On Tue, 6 September 2005 16:17:19 +0100, Richard Purdie wrote:
> On Tue, 2005-09-06 at 17:08 +0200, Jörn Engel wrote:
> > On Tue, 6 September 2005 15:46:18 +0100, rpurdie@infradead.org wrote:
> > > 
> > > -	if (machine_is_husky()) {
> > > +	if (machine_is_husky() || machine_is_borzoi()) {
> > >  		/* Need to use small eraseblock size for backward compatibility */
> > >  		sharpsl_mtd->flags |= MTD_NO_VIRTBLOCKS;
> > >  	}
> > 
> > With Ferenc's patch in, MTD_NO_VIRTBLOCKS has lost its effect.  I
> > guess we will remove that flag sometime in the near future.
> 
> I'm running mainline mtd so I guess I haven't seen this yet.

Fair enough.

> The problem is that on the Sharp Zaurus series we're stuck with a ROM
> bootloader that flashes the partitions in a certain way. The above flag
> allowed us to stay compatible with that and is quite important. I'm not
> sure where this leaves us...

Actually, this flag is important to *everybody*.  Whoever thought up
the hack to use virtual blocks instead of physical ones was plain
stupid and opened the door for incompatibilities, data loss and who
knows what else.

Hence, Ferenc made the flag implicit.  Actually, he was a bit smarter
and only made it implicit when required.  Either way, the virtual
blocks are gone, thankfully.

Jörn

-- 
When in doubt, punt.  When somebody actually complains, go back and fix it...
The 90% solution is a good thing.
-- Rob Landley

Re: mtd/drivers/mtd/nand sharpsl.c,1.4,1.5

[Richard Purdie]

On Tue, 2005-09-06 at 17:22 +0200, Jörn Engel wrote: 
> On Tue, 6 September 2005 16:17:19 +0100, Richard Purdie wrote:
> > On Tue, 2005-09-06 at 17:08 +0200, Jörn Engel wrote:
> > > With Ferenc's patch in, MTD_NO_VIRTBLOCKS has lost its effect.  I
> > > guess we will remove that flag sometime in the near future.
> 
> Actually, this flag is important to *everybody*.  Whoever thought up
> the hack to use virtual blocks instead of physical ones was plain
> stupid and opened the door for incompatibilities, data loss and who
> knows what else.
> 
> Hence, Ferenc made the flag implicit.  Actually, he was a bit smarter
> and only made it implicit when required.  Either way, the virtual
> blocks are gone, thankfully.

Ah, so this flag is enabled for everyone now? If so, that's fine. I was
thinking you meant there was no longer a way to disable virtual blocks
which was worrying me, a lot :)

Cheers,

Richard - relived