From: Pete Popov <ppopov@embeddedalley.com>
To: Leif Lindholm <leif.lindholm@i3micro.com>
Cc: Sergei Shtylylov <sshtylyov@ru.mvista.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH] NAND: Fix NAND ECC errors on AMD Au1550
Date: Mon, 31 Oct 2005 08:00:02 -0800 [thread overview]
Message-ID: <1130774403.12171.111.camel@localhost.localdomain> (raw)
In-Reply-To: <1130769581.6003.43.camel@localhost>
On Mon, 2005-10-31 at 15:39 +0100, Leif Lindholm wrote:
> On Sun, 2005-10-30 at 23:58 -0800, Pete Popov wrote:
> > It works on the Db1550. I need to run a sanity check on the Db1200. If
> > no one has any objections, I'll commit it in the next couple of days
> > after I check the Db1200.
>
> Just a comment (forgot to post this last time around):
> At least one of the chips we're using - identified as
> "NAND device: Manufacturer ID: 0xec, Chip ID: 0x76 (Samsung NAND 64MiB 3,3V 8-bit)"
> seems to also need the CS manually asserted during a READID operation.
>
> This made the if-statements ridicilously long, so I added a case
> statement and a variable keeping track of wether or not to force-enable
> CS to the au1550_command function.
>
> If there is any interest, I could post a patch, but am unsure of the
> correct way. Should I send a new patch against cvs HEAD containing my
> trivial tweak as well as Sergeis modifications, or...?
Send an incremental patch on top of Sergey's patch if you can.
Pete
next prev parent reply other threads:[~2005-10-31 16:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-29 20:44 [PATCH] NAND: Fix NAND ECC errors on AMD Au1550 Sergei Shtylylov
2005-10-30 4:36 ` Pete Popov
2005-10-31 7:58 ` Pete Popov
2005-10-31 14:39 ` Leif Lindholm
2005-10-31 16:00 ` Pete Popov [this message]
2005-11-01 14:49 ` Leif Lindholm
2005-11-01 15:29 ` Sergei Shtylylov
2005-11-01 15:50 ` Leif Lindholm
2005-11-01 16:31 ` Sergei Shtylylov
2005-10-31 17:55 ` Sergei Shtylylov
2005-11-01 8:53 ` Pantelis Antoniou
2005-11-01 12:49 ` Sergei Shtylylov
2005-11-01 13:00 ` Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1130774403.12171.111.camel@localhost.localdomain \
--to=ppopov@embeddedalley.com \
--cc=leif.lindholm@i3micro.com \
--cc=linux-mtd@lists.infradead.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox