public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	bunk@stusta.de
Subject: Re: [2.6 patch] no longer mark MTD_OBSOLETE_CHIPS as BROKEN and remove broken MTD_OBSOLETE_CHIPS drivers
Date: Sun, 08 Jan 2006 12:41:12 +0000	[thread overview]
Message-ID: <1136724072.30348.66.camel@pmac.infradead.org> (raw)
In-Reply-To: <20060107174523.460f1849.akpm@osdl.org>

On Sat, 2006-01-07 at 17:45 -0800, Andrew Morton wrote:
> Hey, Adrian isn't an MTD developer

Indeed he is not. And while his minor nitpicks can sometimes be worth
the effort, it's less useful for him to start making value judgements
about removing drivers which have _theoretically_ been replaced by new
code, but which are actually still being used in some cases.

> What he's doing here is to poke other maintainers into getting the tree
> cleaned up.  It's a useful thing to do.

I know what needs doing to clean the tree up -- and removing the older
chip drivers is very far from the top of my todo list. If you really
want to accelerate their demise, add a #warning and a printk saying "You
should no longer be using this driver -- try using jedec_probe or
cfi_probe instead and contact the linux-mtd list if that fails". 

> If you, an MTD maintainer, can tell him what we _should_ be doing, I'm sure
> Adrian would help.

That would be much appreciated -- and _useful_. We need to add sysfs
support to MTD devices, we need to revamp the way that the chip probe
code hands off to the back-end chip drivers, and in doing so get rid of
the use of inter_module_crap(), and we need to audit the module
refcounting while we're at it.

I'm hoping I'll get a week or two some time soon to sit down and
actually concentrate on that, because it's not something I can really
pick at piecemeal and it wants proper testing. But if Adrian wants to
have a go, that would be wonderful.

But picking away at what looks like low-hanging fruit without a real
understanding of what's going on doesn't really help much.

-- 
dwmw2

  reply	other threads:[~2006-01-08 12:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-07 22:07 [2.6 patch] no longer mark MTD_OBSOLETE_CHIPS as BROKEN and remove broken MTD_OBSOLETE_CHIPS drivers Adrian Bunk
2006-01-08  0:00 ` David Woodhouse
2006-01-08  0:24   ` Adrian Bunk
2006-01-08  0:38     ` David Woodhouse
2006-01-08  1:45       ` Andrew Morton
2006-01-08 12:41         ` David Woodhouse [this message]
2006-01-08 12:57           ` Adrian Bunk
2006-01-08 13:06             ` David Woodhouse
2006-01-08 14:14               ` [2.6 patch] no longer mark MTD_OBSOLETE_CHIPS as BROKEN Adrian Bunk
2006-01-08 14:24                 ` David Woodhouse
  -- strict thread matches above, loose matches on Subject: below --
2006-01-06 18:14 [2.6 patch] no longer mark MTD_OBSOLETE_CHIPS as BROKEN and remove broken MTD_OBSOLETE_CHIPS drivers Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1136724072.30348.66.camel@pmac.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox