public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Brian Norris" <computersforpeace@gmail.com>,
	"David Woodhouse" <dwmw2@infradead.org>,
	"Boris Brezillon" <boris.brezillon@free-electrons.com>,
	"Marek Vasut" <marek.vasut@gmail.com>,
	"Cyrille Pitchen" <cyrille.pitchen@wedev4u.fr>,
	linux-mtd@lists.infradead.org, "Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] mtd: update documentation of mtd_device_parse_register()
Date: Tue, 27 Mar 2018 21:18:14 +0200	[thread overview]
Message-ID: <11374740.7K3gF4UMb0@blindfold> (raw)
In-Reply-To: <20180327133647.15110-1-zajec5@gmail.com>

Am Dienstag, 27. März 2018, 15:36:47 CEST schrieb Rafał Miłecki:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> In the commit 2c77c57d22adb ("mtd: move code adding master MTD out of
> mtd_add_device_partitions()") behavior of mtd_device_parse_register()
> has very slightly changed. It's a pretty non-significant order change
> to match updated function behavior.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>  drivers/mtd/mtdcore.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> index f25d65ea7149..20d5262c5b5c 100644
> --- a/drivers/mtd/mtdcore.c
> +++ b/drivers/mtd/mtdcore.c
> @@ -673,14 +673,13 @@ static void mtd_set_dev_defaults(struct mtd_info *mtd)
>   * 'parse_mtd_partitions()') and MTD device and partitions registering. It
>   * basically follows the most common pattern found in many MTD drivers:
>   *
> - * * It first tries to probe partitions on MTD device @mtd using parsers
> + * * If the MTD_PARTITIONED_MASTER option is set, then the device as a whole is
> + *   registered first.
> + * * Then It tries to probe partitions on MTD device @mtd using parsers
>   *   specified in @types (if @types is %NULL, then the default list of parsers
>   *   is used, see 'parse_mtd_partitions()' for more information). If none are
>   *   found this functions tries to fallback to information specified in
>   *   @parts/@nr_parts.
> - * * If any partitioning info was found, this function registers the found
> - *   partitions. If the MTD_PARTITIONED_MASTER option is set, then the device
> - *   as a whole is registered first.
>   * * If no partitions were found this function just registers the MTD device
>   *   @mtd and exits.
>   *
> 

Thanks for taking care of docs. :-)

Reviewed-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard

  reply	other threads:[~2018-03-27 19:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-27 13:36 [PATCH] mtd: update documentation of mtd_device_parse_register() Rafał Miłecki
2018-03-27 19:18 ` Richard Weinberger [this message]
2018-03-29 20:21   ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11374740.7K3gF4UMb0@blindfold \
    --to=richard@nod.at \
    --cc=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=rafal@milecki.pl \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox