From: Thomas Gleixner <tglx@linutronix.de>
To: Andrew Victor <andrew@sanpeople.com>
Cc: linux-mtd@lists.infradead.org, Ben Dooks <ben-mtd@fluff.org>
Subject: Re: NAND driver for AT91RM9200
Date: Tue, 21 Feb 2006 09:32:42 +0100 [thread overview]
Message-ID: <1140510762.2480.847.camel@localhost.localdomain> (raw)
In-Reply-To: <1140509194.16321.21.camel@fuzzie.sanpeople.com>
On Tue, 2006-02-21 at 10:06 +0200, Andrew Victor wrote:
> Hopefully the driver is now acceptable for addition to the MTD CVS /
> mainline kernels. Thanks.
Can you please fix up the lines with >80 characters ?
> + /* Allocate memory for the device structure */
> + host = kmalloc(sizeof(struct at91_nand_host), GFP_KERNEL);
> + if (!host) {
> + printk(KERN_ERR "at91_nand: failed to allocate device structure.\n");
> + return -ENOMEM;
> + }
> + memset(host, 0, sizeof(struct at91_nand_host));
Please use kzalloc
tglx
next prev parent reply other threads:[~2006-02-21 8:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-20 14:54 NAND driver for AT91RM9200 Andrew Victor
2006-02-20 15:35 ` Ben Dooks
2006-02-20 19:59 ` Thomas Gleixner
2006-02-21 8:06 ` Andrew Victor
2006-02-21 8:32 ` Thomas Gleixner [this message]
2006-02-21 9:36 ` Andrew Victor
2006-02-20 15:43 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1140510762.2480.847.camel@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=andrew@sanpeople.com \
--cc=ben-mtd@fluff.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox