From: David Woodhouse <dwmw2@infradead.org>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: linux-mtd@lists.infradead.org
Subject: Re: A JFFS2 optimization related to syslog
Date: Sun, 14 May 2006 04:22:46 +0100 [thread overview]
Message-ID: <1147576966.19840.2.camel@shinybook.infradead.org> (raw)
In-Reply-To: <20060419125551.GA1185@wohnheim.fh-wedel.de>
On Wed, 2006-04-19 at 14:55 +0200, Jörn Engel wrote:
>
> Too complicated, imo. The patch writes a pristine node, if
> 1) node is last node of page,
> 2) node is last node of file,
> 3) other nodes exist in the same eraseblock.
>
> Condition 1 makes sense. 2 can be argued about. Maybe a benchmark or
> two can show whether it makes sense or not. 3 is fairly complicated
> and I fail to see what it buys us. If the other fragments are in
> seperate eraseblocks, why shouldn't we write out a pristine node?
Fair enough. I've committed a (cosmetic) variant of Ferenc's original
patch then.
--
dwmw2
next prev parent reply other threads:[~2006-05-14 3:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-18 11:09 A JFFS2 optimization related to syslog Ferenc Havasi
2006-04-18 11:32 ` Jörn Engel
2006-04-19 11:00 ` David Woodhouse
2006-04-19 12:45 ` David Woodhouse
2006-04-19 12:55 ` Jörn Engel
2006-05-14 3:22 ` David Woodhouse [this message]
2006-04-18 11:46 ` Artem B. Bityutskiy
2006-04-18 11:51 ` Artem B. Bityutskiy
2006-04-18 12:05 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1147576966.19840.2.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox