From: David Woodhouse <dwmw2@infradead.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [-mm patch] make drivers/mtd/nand/cs553x_nand.c:cs553x_init() static
Date: Tue, 16 May 2006 14:04:19 +0100 [thread overview]
Message-ID: <1147784659.27870.43.camel@pmac.infradead.org> (raw)
In-Reply-To: <20060516123750.GS6931@stusta.de>
On Tue, 2006-05-16 at 14:37 +0200, Adrian Bunk wrote:
> This patch makes the needlessly global cs553x_init() static.
NAK. That problem was inherited from another board driver which was
copied and modified. And that driver inherited it in turn... let's not
piss about with them one at a time; let's just fix them _all_ at once,
instead. And let's remove the bizarre use of '#ifdef MODULE' around the
cleanup functions while we're at it.
http://git.infradead.org/?p=mtd-2.6.git;a=commitdiff;h=cead4dbc03ba6eb2e35bac04439b76a0cc2286ce
--
dwmw2
prev parent reply other threads:[~2006-05-16 13:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060515005637.00b54560.akpm@osdl.org>
2006-05-16 10:25 ` 2.6.17-rc4-mm1: no help text for MTD_NAND_CS553 Adrian Bunk
2006-05-16 12:13 ` David Woodhouse
2006-05-16 11:46 ` [-mm patch] drivers/mtd/devices/docprobe.c: correct #if's Adrian Bunk
2006-05-16 12:14 ` David Woodhouse
2006-05-16 12:37 ` [-mm patch] make drivers/mtd/nand/cs553x_nand.c:cs553x_init() static Adrian Bunk
2006-05-16 13:04 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1147784659.27870.43.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox