Re: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static

[David Woodhouse <dwmw2@infradead.org>]

On Thu, 2006-06-29 at 19:32 +0200, Adrian Bunk wrote:
> On Tue, Jun 27, 2006 at 02:49:00PM +0100, David Woodhouse wrote:
> > On Tue, 2006-06-27 at 00:02 +0200, Adrian Bunk wrote:
> > > This patch makes the needlessly global mtdpart_setup() static.
> > > 
> > > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > > 
> > > --- linux-2.6.17-mm2-full/drivers/mtd/cmdlinepart.c.old 2006-06-26 23:18:39.000000000 +0200
> > > +++ linux-2.6.17-mm2-full/drivers/mtd/cmdlinepart.c     2006-06-26 23:18:51.000000000 +0200
> > > @@ -346,7 +346,7 @@
> > >   *
> > >   * This function needs to be visible for bootloaders.
> > >   */
> > > -int mtdpart_setup(char *s)
> > > +static int mtdpart_setup(char *s) 
> > 
> > Patch lacks sufficient explanation. Explain the relevance of the comment
> > immediately above the function declaration, in the context of your
> > patch. Explain your decision to change the behaviour, but not change the
> > comment itself.
> 
> My explanation regarding the relevance of the comment is that it seems 
> to be nonsense.
> 
> Do I miss something, or why and how should a bootloader access 
> in-kernel functions? 

I'm not entirely sure, but allegedly it does -- Juha, can you elaborate?

-- 
dwmw2