From: Richard Purdie <rpurdie@rpsys.net>
To: tglx@linutronix.de, David Woodhouse <dwmw2@infradead.org>
Cc: Steven Newbury <s_j_newbury@yahoo.co.uk>, linux-mtd@lists.infradead.org
Subject: [PATCH] MTD: [NAND] Fix the sharpsl driver after breakage from a core conversion
Date: Sat, 15 Jul 2006 13:05:24 +0100 [thread overview]
Message-ID: <1152965125.13315.0.camel@localhost.localdomain> (raw)
MTD: [NAND] Fix the sharpsl driver after breakage from a core conversion
The CNE bits are inverted on the device and writeb function is missing a
NOT operation.
Signed-off-by: Richard Purdie <rpurdie@rpsys.net>
Index: git/drivers/mtd/nand/sharpsl.c
===================================================================
--- git.orig/drivers/mtd/nand/sharpsl.c 2006-07-15 12:47:53.000000000 +0100
+++ git/drivers/mtd/nand/sharpsl.c 2006-07-15 12:06:31.000000000 +0100
@@ -78,7 +78,7 @@
/*
* hardware specific access to control-lines
* ctrl:
- * NAND_CNE: bit 0 -> bit 0 & 4
+ * NAND_CNE: bit 0 -> ! bit 0 & 4
* NAND_CLE: bit 1 -> bit 1
* NAND_ALE: bit 2 -> bit 2
*
@@ -92,7 +92,10 @@
unsigned char bits = ctrl & 0x07;
bits |= (ctrl & 0x01) << 4;
- writeb((readb(FLASHCTL) & 0x17) | bits, FLASHCTL);
+
+ bits ^= 0x11;
+
+ writeb((readb(FLASHCTL) & ~0x17) | bits, FLASHCTL);
}
if (cmd != NAND_CMD_NONE)
reply other threads:[~2006-07-15 12:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1152965125.13315.0.camel@localhost.localdomain \
--to=rpurdie@rpsys.net \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=s_j_newbury@yahoo.co.uk \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox