public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind@infradead.org>
To: Vijay Kumar <vijaykumar@bravegnu.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/2] NAND: nandsim sector-wise allocation
Date: Fri, 06 Oct 2006 09:49:17 +0300	[thread overview]
Message-ID: <1160117357.13696.37.camel@sauron> (raw)
In-Reply-To: <17701.15123.205461.480037@vaishnavi.localdomain>

On Thu, 2006-10-05 at 22:34 +0530, Vijay Kumar wrote:
> The existing config options related to chip mapping and chip-wise
> allocation are moved to kernel configuration system.

BTW, it is a nice idea to add Signed-off-by, just a note for future
patches :-)

> 
> Index: linux-2.6-mtd-quilt/drivers/mtd/nand/Kconfig
> ===================================================================
> --- linux-2.6-mtd-quilt.orig/drivers/mtd/nand/Kconfig	2006-10-01 18:56:35.000000000 +0530
> +++ linux-2.6-mtd-quilt/drivers/mtd/nand/Kconfig	2006-10-01 20:35:47.000000000 +0530
> @@ -239,4 +239,28 @@
>  	  The simulator may simulate various NAND flash chips for the
>  	  MTD nand layer.
>  
> +choice 
> +	depends on MTD_NAND_NANDSIM
> +	prompt "Mapping/allocation method"
> +	default MTD_NAND_NANDSIM_CHIP_ALLOC
> +
> +config  MTD_NAND_NANDSIM_CHIP_MAP
> +	bool "Mapped flash image"
> +	help
> +	  The flash data is stored in an image mapped to memory.
Is this option really needed? I've never heard somebody using it. Do you
use it? If no, will you mind to get rid of it at all? And then of course
MTD_NAND_NANDSIM_CHIP_ALLOC won't be needed as well.

-- 
Best Regards,
Artem Bityutskiy (Битюцкий Артём)

  reply	other threads:[~2006-10-06  6:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-05 16:57 [PATCH 0/2] NAND: nandsim sector-wise allocation Vijay Kumar
2006-10-05 17:04 ` [PATCH 1/2] " Vijay Kumar
2006-10-06  6:49   ` Artem Bityutskiy [this message]
2006-10-08  5:38     ` Vijay Kumar
2006-10-05 17:13 ` [PATCH 2/2] " Vijay Kumar
2006-10-06  7:08   ` Artem Bityutskiy
2006-10-08  5:50     ` Vijay Kumar
2006-10-06  6:44 ` [PATCH 0/2] " Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1160117357.13696.37.camel@sauron \
    --to=dedekind@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=vijaykumar@bravegnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox